Summary: | [Workbench] setting WorkbenchLogger regardless of the ILoggerProvider | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Jan Weidauer <jan.weidauer> |
Component: | UI | Assignee: | Jonas Helming <jhelming> |
Status: | NEW --- | QA Contact: | |
Severity: | enhancement | ||
Priority: | P3 | CC: | jhelming, Lars.Vogel |
Version: | 4.4 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Windows 7 | ||
Whiteboard: |
Description
Jan Weidauer
2013-11-29 03:08:52 EST
Sounds reasonable. Would you be able to provide a Gerrit review for that, so that we can code review your suggestion? See http://www.vogella.com/articles/Gerrit/article.html#eclipsegerritcontribution for an introduction to Gerrit contributions for Eclipse. I think the ILoggerProvider does not really fit, as it requires a Class<?>. The "root" logger for the application is currently not instantiated with any specific class. I therefore suggest to: - Check if a Logger is existing in the context (service or app context) - If so, use this one - If not, instantiate the default one as before This would enable to replace the Logger just by registering an OSGi service or a context function. Would the proposed solution solve your issue? |