Bug 419804

Summary: [regression] Servlets should not be disabled by default
Product: [WebTools] WTP Java EE Tools Reporter: Carl Anderson <ccc>
Component: jst.j2eeAssignee: Carl Anderson <ccc>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: critical    
Priority: P1 CC: cbridgha, ccc, david_williams, kaloyan, keith.chong.ca, naci.dai, neil.hauge, raghunathan.srinivasan
Version: 3.5.1Flags: ccc: pmc_approved? (david_williams)
ccc: pmc_approved? (raghunathan.srinivasan)
ccc: pmc_approved? (naci.dai)
neil.hauge: pmc_approved+
ccc: pmc_approved? (cbridgha)
ccc: pmc_approved? (kaloyan)
cbridgha: review+
Target Milestone: 3.5.1 P   
Hardware: PC   
OS: Windows XP   
Whiteboard: PMC
Bug Depends on: 305066, 418957    
Bug Blocks:    
Attachments:
Description Flags
Set the default to true none

Description Carl Anderson CLA 2013-10-18 01:36:32 EDT 
+++ This bug was initially created as a clone of Bug #418957 +++

+++ This bug was initially created as a clone of Bug #305066 +++

In the model regeneration for Java EE 6 (now, 7), the default for the new <enabled> attribute for servlets is false.  That means that any servlet created will not be available on the server - see section 8.2.2 of the Servlet 3.0 specification.  That is bad - we need the default to be enabled, not disabled.

This is a serious bug.  The fix should be made available to all WTP users ASAP.
Comment 1 Carl Anderson CLA 2013-10-18 01:41:40 EDT 
Created attachment 236635 [details]
Set the default to true
Comment 2 Carl Anderson CLA 2013-10-21 11:24:52 EDT 
This is a regression in WTP 3.5.x that effects Servlets created in Java EE 5, 6, and 7.  There is now a patch available at http://download.eclipse.org/webtools/downloads/drops/R3.5.1/R-3.5.1-20130913223750/
Comment 3 Carl Anderson CLA 2013-10-21 11:33:03 EDT 
PMC approval requested to make this patch public.

Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.

This bug would have been considered stop-ship if it had been found before WTP was released.  It needs to be fixed in 3.5.2 (see bug 218957), and we need a public patch available as soon as possible.

Is there a work-around? If so, why do you believe the work-around is insufficient? 

The workaround is to manually enable each servlet after it is created.  This is not user-friendly, and quite error-prone.

How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

The Java EE JUnit bucket has been run against this fix.

Give a brief technical overview. Who has reviewed this fix? 

In the EMF model, the default for Servlet enablement has been switched back to true.  Chuck Bridgham has reviewed this fix.

What is the risk associated with this fix? 

This is an extremely low risk fix- we are undoing an accidental change.
Comment 4 Carl Anderson CLA 2013-10-31 14:15:11 EDT 
The patch has been made public, in the WTP kepler repository.