Bug 411708

Summary:	NPE When comparing with no remote
Product:	z_Archived	Reporter:	Miles Parker <milesparker>
Component:	Mylyn	Assignee:	Miles Parker <milesparker>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	sam.davis
Version:	unspecified
Target Milestone:	2.0.1
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:
Bug Blocks:	411652

Description Miles Parker

2013-06-26 12:58:01 EDT

If you attempt to compare with another patch set after disconnecting to an existing remote, you get an NPE.

java.lang.NullPointerException
	at org.eclipse.mylyn.internal.gerrit.core.remote.PatchSetContentRemoteFactory.pull(PatchSetContentRemoteFactory.java:66)
	at org.eclipse.mylyn.internal.gerrit.core.remote.PatchSetContentCompareRemoteFactory.pull(PatchSetContentCompareRemoteFactory.java:38)
	at org.eclipse.mylyn.internal.gerrit.core.remote.PatchSetContentCompareRemoteFactory.pull(PatchSetContentCompareRemoteFactory.java:1)
	at org.eclipse.mylyn.reviews.core.spi.remote.emf.RemoteEmfConsumer.pull(RemoteEmfConsumer.java:164)
	at org.eclipse.mylyn.reviews.core.spi.remote.JobRemoteService$1.run(JobRemoteService.java:60)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

Comment 1 Miles Parker

2013-06-26 13:26:26 EDT

This issue was introduced when solving the issue of how to deal with patch sets when only one commit was not available. The current code now absorbs and logs the exception but that doesn't work for some cases where the issue was caused by no connectivity.

Comment 2 Miles Parker

2013-06-26 13:41:05 EDT

https://git.eclipse.org/r/14077 (Please ignore spurious test exception.)

Comment 3 Miles Parker

2013-07-03 19:46:35 EDT

Merged https://git.eclipse.org/r/14077.