Bug 410442

Summary:	expanding of patch set fails with error dialog when offline
Product:	z_Archived	Reporter:	Steffen Pingel <steffen.pingel>
Component:	Mylyn	Assignee:	Miles Parker <milesparker>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	2.0.1
Hardware:	Macintosh
OS:	Mac OS X
Whiteboard:
Bug Depends on:	411320
Bug Blocks:

Description Steffen Pingel

2013-06-11 06:23:39 EDT

Steps:
1. Disconnect from network
2. Expand a patch set that wasn't cached previously

An error dialog appears:

java.lang.NullPointerException
	at org.eclipse.mylyn.internal.gerrit.core.remote.PatchSetContentRemoteFactory.pull(PatchSetContentRemoteFactory.java:65)
	at org.eclipse.mylyn.internal.gerrit.core.remote.PatchSetContentIdRemoteFactory.pull(PatchSetContentIdRemoteFactory.java:48)
	at org.eclipse.mylyn.internal.gerrit.core.remote.PatchSetContentIdRemoteFactory.pull(PatchSetContentIdRemoteFactory.java:1)
	at org.eclipse.mylyn.reviews.core.spi.remote.emf.RemoteEmfConsumer.pull(RemoteEmfConsumer.java:164)
	at org.eclipse.mylyn.reviews.core.spi.remote.JobRemoteService$1.run(JobRemoteService.java:60)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)

Comment 1 Steffen Pingel

2013-06-11 06:32:50 EDT

The same stack trace appears when I use Compare With Base on a patch set that hasn't been loaded.

Comment 2 Miles Parker

2013-06-11 13:15:00 EDT

Hmmm... on my machine when you try this you get an appropriate error message in the patch set. Not sure why it's different here, perhaps a platform thing.

Comment 3 Miles Parker

2013-06-20 17:51:04 EDT

https://git.eclipse.org/r/13964 (Should fix and provide error message.)

Comment 4 Miles Parker

2013-06-21 18:28:05 EDT

Merged https://git.eclipse.org/r/13964