Summary: | [Eclipse Platform Utilities] incorrect implementation in org.eclipse.sphinx.platform.ui.preferences.AbstractPreferenceAndPropertyPage | ||||||
---|---|---|---|---|---|---|---|
Product: | [Automotive] Sphinx | Reporter: | pdu <pierre.dufay> | ||||
Component: | Core | Assignee: | Project Inbox <sphinx-inbox> | ||||
Status: | CLOSED WONTFIX | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | balazs.grill, idydieng, pierre.dufay, r.sezestre | ||||
Version: | 0.7.0 | ||||||
Target Milestone: | --- | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
pdu
2013-04-10 08:42:28 EDT
Created attachment 229552 [details]
patch proposal
This patch applies on sphinx svn trunk
Further investigation show that the previously sent patch is not totally effective. As a matter of fact, with this patch, 'composite' variable is useless, but nevertheless added to parent. This leads in display problem when adding StringFieldEditor. As a conclusion, added to this patch, code linked to 'composite' variable must be removed: protected void createFieldEditors() { Composite parent = getFieldEditorParent(); initializeDialogUnits(parent); GridLayout layout = new GridLayout(); layout.marginHeight = convertVerticalDLUsToPixels(IDialogConstants.VERTICAL_MARGIN); layout.marginWidth = 0; layout.verticalSpacing = convertVerticalDLUsToPixels(10); layout.horizontalSpacing = convertHorizontalDLUsToPixels(IDialogConstants.HORIZONTAL_SPACING); parent.setLayout(layout); parent.setLayoutData(new GridData(GridData.FILL_HORIZONTAL)); addFields(parent); } Closed stale issue before migration |