Summary: | Errors when using F3 in a html file | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Olivier Thomann <Olivier_Thomann> |
Component: | UI | Assignee: | Douglas Pollock <douglas.pollock> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | critical | ||
Priority: | P1 | CC: | n.a.edgar |
Version: | 3.0 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Windows 2000 | ||
Whiteboard: |
Description
Olivier Thomann
2003-07-17 11:22:52 EDT
The open declaration action is defined in XML as retarget="true" so there isn't a class attribute. The real action is set in code by using actionBars.setGlobalActionHandler(JdtActionConstants.OPEN, fOpen) and we don't provide an action handler for open for HTML files. The action seems to be enabled also no action handler is registered. Moving to Platform UI. The Java Open Actions action set must have been previously activated. Steps to reproduce: - new workspace - new Java project Test (say no to switch perspective prompt) - new Java class A - close it - new file: B.txt - F3 in editor - error occurs It should not get to the plugin action for Open since the Java Open Actions action set is not enabled for plain text editors. Stack is: Thread [main] (Suspended (breakpoint at line 206 in WWinPluginAction)) WWinPluginAction.runWithEvent(Event) line: 206 ActionHandler.execute(Event) line: 39 ContextAndHandlerManager.pressed(Stroke, Event) line: 180 ContextAndHandlerManager.access$1(ContextAndHandlerManager, Stroke, Event) line: 165 ContextAndHandlerManager$7.widgetSelected(SelectionEvent) line: 274 AcceleratorMenu$2.handleEvent(Event) line: 68 EventTable.sendEvent(Event) line: 82 MenuItem(Widget).sendEvent(Event) line: 848 Display.runDeferredEvents() line: 2188 Display.readAndDispatch() line: 1878 Workbench.runEventLoop(Window$IExceptionHandler) line: 1630 Workbench.run(Object) line: 1613 InternalBootLoader.run(String, URL, String, String[], Runnable) line: 858 BootLoader.run(String, URL, String, String[], Runnable) line: 461 Method.invoke(Object, Object[]) line: not available [native method] Main.basicRun(String[]) line: 291 Main.run(String[]) line: 747 Main.main(String[]) line: 583 WWinPluginAction could be improved to not try to load the class if it's a retargetable action, but it should not even be getting this far. I can't reproduce this bug (as described by Olivier) -- using Windows XP or Linux-GTK. I've tried Nick's steps on Linux-GTK and also no dice. I've also set a breakpoint at "WWinPluginAction.runWithEvent(Event) line: 206" and never reached it (doing Nick's steps). Could someone else confirm that this bug is gone? I'm using Eclipse-3.0M3. Thanks. I can't reproduce it either. code in this area was heavily modified since 7/17. closing as fixed. olivier, please reopen if you can reproduce this problem in M3. |