Bug 402005

Summary: Add support for source lookup for a new Equinox implementation
Product: [Eclipse Project] PDE Reporter: Thomas Watson <tjwatson>
Component: UIAssignee: Curtis Windatt <curtis.windatt.public>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: curtis.windatt.public
Version: 4.3Keywords: contributed
Target Milestone: 4.3 M6   
Hardware: PC   
OS: Mac OS X   
Whiteboard:
Attachments:
Description Flags
Fix to support refactored Equinox none

Description Thomas Watson CLA 2013-02-28 09:20:04 EST 
Created attachment 227727 [details]
Fix to support refactored Equinox

I have a refactored Equinox framework implementation that changes the internals for the bundle class loaders that will require a change to PDE in order to support source lookup for bundles.

The attached patch does not add any new dependencies on the new framework and will still work on the old frameworks.  It would be good to get this released in Kepler so that I can have folks try out the new framework implementation with Kepler without any patching of PDE.

The patch removes an access call to the 'data' field of the 'manager'.  I did not see any reason for getting that IJavaObject since it was not used anywhere other than to do a null check, but that is not necessary since we only act upon the manager object here (and the refactored framework no longer has this 'data' field on the 'manager' object.

	IJavaObject data = getObject(manager, "data", false); //$NON-NLS-1$
	if (data != null) { ... }
Comment 1 Curtis Windatt CLA 2013-02-28 15:52:38 EST 
Changes look fine, doesn't cause any problems with current classloader.  Added a comment to the constant pointing to this bug.

http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=98756305ad049a92fd101b6d0f4a7a8bbe0f24b1

Thanks Tom.