Summary: | RSEInitJob runs too early | ||||||
---|---|---|---|---|---|---|---|
Product: | [Tools] Target Management | Reporter: | David Dykstal <ddykstal.eclipse> | ||||
Component: | RSE | Assignee: | David Dykstal <ddykstal.eclipse> | ||||
Status: | RESOLVED FIXED | QA Contact: | David Dykstal <ddykstal.eclipse> | ||||
Severity: | critical | ||||||
Priority: | P1 | CC: | dmcknigh, g.watson | ||||
Version: | 3.4.1 | Flags: | dmcknigh:
review+
|
||||
Target Milestone: | 3.4.2 | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Whiteboard: | |||||||
Bug Depends on: | |||||||
Bug Blocks: | 400345 | ||||||
Attachments: |
|
Description
David Dykstal
2013-01-11 11:46:15 EST
Dave - please review the patch in branch dwd-move-init-trial. The change moves the scheduling of the RSEInitJob to org.eclipse.rse.ui from org.eclipse.rse.core. The RSEInitJob and its query API remains unchanged in core, only its scheduling has been changed. I looked at and tried out the changes and I don't see any problems so I think this is good to go. Added the version and copyright changes that DaveM suggested from his review. Reopening for problem found in PTP initialization. Created attachment 226947 [details]
patch to exploit org.eclipse.ui.startup
This patch moves the scheduling from the UI plugin activation to a separate class invoked by org.eclipse.ui.startup. It was previously possible to start the workbench and wait for the init job to finish and not have it started if the RSE UI was not activated. By using org.eclipse.ui.startup we avoid the problem.
Dave - please review the patch. This patch appears to resolve the issue for PTP. The patch looks okay to me. Fix has been tested by PTP |