Summary: | Allow to use addons separatedly from "org.eclipse.e4.ui.workbench.addons.swt" | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Alex Kipling <anenada> | ||||
Component: | UI | Assignee: | Nis Wechselberg <enbewe> | ||||
Status: | RESOLVED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | daniel.kruegler, flavio.donze, georg.fiechtner, kon, Lars.Vogel, nobody, peter, wechselberg.nisboerge, wim.jongman | ||||
Version: | 4.2.1 | Keywords: | bugday, noteworthy | ||||
Target Milestone: | 4.15 M1 | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
See Also: |
https://git.eclipse.org/r/153984 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1e179a14360c8907ec88e727dfa598a666d5d833 https://git.eclipse.org/r/154409 https://git.eclipse.org/r/154410 https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=485598bcba96cc925f1dd9d0dcc77494f40364be |
||||||
Whiteboard: | |||||||
Bug Depends on: | |||||||
Bug Blocks: | 394333 | ||||||
Attachments: |
|
Description
Alex Kipling
2012-11-13 17:28:45 EST
Alex is planning to provide a patch. The problem here is that we automatically register the addons (all of them) using a model processor contribution. This is obviously wrong. Lars the package splitting we were talking about would also fix this correct ? Alex, for now you might consider adding a LifeCycle handler and have its 'ProcessRemovals' remove the instance of the MinMaxAddon from the model (I just looked and this *is* done before the addons get instantiated... @Eric, yes splitting it up would solve this bug. Lets use this bug for the split of the Add-on bundles. (In reply to comment #4) > @Eric, yes splitting it up would solve this bug. Lets use this bug for the > split of the Add-on bundles. Would then there be two min-max addons? We plan to split the following Addons into separate bundles: - CleanupAddon - MinMaxAddon - DndAddon Created attachment 223577 [details]
Splitted bundles
The attached zip file contains the three new bundles.
If they get accepted, I will provide a patch for removing org.eclipse.e4.ui.workbench.addons.swt and for adjusting the org.eclipse.e4.rcp feature.
The Eclipse 4 wizard does not need to get adjusted, we currently do not add the org.eclipse.e4.ui.workbench.addons.swt during the generation of a new application.
Hey everybody, I just wanted to check on the status of this defect. I guess the patch has not been accepted yet? Is there something that can be done to get this a bump in attention? :) I would especially be interested in having a tag to enable or disable Min-Max buttons for parts explicitly. Our use case is the following: we have many parts that can be maximized/minimized, except one, that acts like a Dashboard which always stays prominently in maximized state. So for that part, being able to hide these buttons would be handy. (In reply to Georg Fiechtner from comment #8) > I would especially be interested in having a tag to enable or disable > Min-Max buttons for parts explicitly. > Our use case is the following: we have many parts that can be > maximized/minimized, except one, that acts like a Dashboard which always > stays prominently in maximized state. So for that part, being able to hide > these buttons would be handy. This is a different feature request. Can you open a new bug report for that request? *** Bug 394333 has been marked as a duplicate of this bug. *** I suggest to solve that via a tag. Each add-on could define a tag and check its existence on the application model. If a tag relevant for an model add-on is present it could deactivate itself. (In reply to Lars Vogel from comment #12) > I suggest to solve that via a tag. Each add-on could define a tag and check > its existence on the application model. If a tag relevant for an model > add-on is present it could deactivate itself. Is the problem that plugin adds the add-ons to the model via a fragment or processor? Or is the min/max addon doing something without having its add on processed? PW With xpath in 4.5. we can change the contribution of the addon from a processor to a model fragment. This way the customer can deactivate it again via a model processor. Any updates on this issue? We also run into this problem when trying to modify maximize behaviour. We cannot remove "org.eclipse.e4.ui.workbench.addons.swt" plug-in, as it is required by "org.eclipse.ui.workbench", which we need for our RCP application as well. Nis indicated that he is interested in providing a patch. New Gerrit change created: https://git.eclipse.org/r/153984 Gerrit change https://git.eclipse.org/r/153984 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1e179a14360c8907ec88e727dfa598a666d5d833 Thanks Nils. Could you provide a N&N entry for this feature via Gerrit? See https://git.eclipse.org/r/c/154405/1 for an example. New Gerrit change created: https://git.eclipse.org/r/154409 New Gerrit change created: https://git.eclipse.org/r/154410 Done that, but I somewhat messed up the formatting on the first commit and then messed up creating a second patch set for the change (In reply to Nis Wechselberg from comment #22) > Done that, but I somewhat messed up the formatting on the first commit and > then messed up creating a second patch set for the change Can you squash them into the first commit and update the Gerrit? Ah, got that resolved ... Not used to Gerrit and Change-Ids and all that whizbang Gerrit change https://git.eclipse.org/r/154409 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=485598bcba96cc925f1dd9d0dcc77494f40364be |