Bug 379182

Summary:	Test failures running PDE build tests on Hudson
Product:	[Eclipse Project] PDE	Reporter:	John Arthorne <john.arthorne>
Component:	Build	Assignee:	John Arthorne <john.arthorne>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	tanis
Version:	4.2	Keywords:	test
Target Milestone:	3.8 RC1
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:	378662
Bug Blocks:

Description John Arthorne

2012-05-10 16:02:14 EDT

There are two test failures when running PDE tests on Hudson (windows and linux). Note this is also the first time running PDE build tests in 4.2 builds.

1) 

testBug183924	Error	Unable to find feature "org.eclipse.e4.rcp" with version in range [1.1.0.v20120131-1846-8yFTEFygGGduEKAaxP4Lpcqr,1.1.0.v20120131-1846-8yFTEFygGGduEKAaxP4Lpcqr].

C:\hb\workspace\JUnit-win2\workarea\I20120509-1900\eclipse-testing\test-eclipse\eclipse\plugins\org.eclipse.pde.build_3.8.0.v20120428-0109\scripts\genericTargets.xml:111: Unable to find feature "org.eclipse.e4.rcp" with version in range [1.1.0.v20120131-1846-8yFTEFygGGduEKAaxP4Lpcqr,1.1.0.v20120131-1846-8yFTEFygGGduEKAaxP4Lpcqr].
at org.eclipse.pde.internal.build.tasks.BuildScriptGeneratorTask.execute(BuildScriptGeneratorTask.java:94)
at org.eclipse.ant.internal.core.ant.EclipseDefaultExecutor.executeTargets(EclipseDefaultExecutor.java:32)
at org.eclipse.ant.internal.core.ant.InternalAntRunner.run(InternalAntRunner.java:672)
at org.eclipse.ant.internal.core.ant.InternalAntRunner.run(InternalAntRunner.java:537)
at org.eclipse.ant.core.AntRunner.run(AntRunner.java:513)
at org.eclipse.pde.build.tests.PDETestCase.runAntScript(PDETestCase.java:144)
at org.eclipse.pde.build.tests.PDETestCase.runAntScript(PDETestCase.java:137)
at org.eclipse.pde.build.tests.PDETestCase.generateScripts(PDETestCase.java:133)
at org.eclipse.pde.build.internal.tests.ScriptGenerationTests.testBug183924(ScriptGenerationTests.java:156)

2)

testBug238001	Failure	expected:<604> but was:<0>

junit.framework.AssertionFailedError: expected:<604> but was:<0>
at org.eclipse.pde.build.internal.tests.ProductTests.testBug238001(ProductTests.java:263)

Comment 1 John Arthorne

2012-05-10 17:23:53 EDT

(In reply to comment #0)
> testBug183924    Error    Unable to find feature "org.eclipse.e4.rcp" with
> version in range

This test is failing because it was making an assumption that the org.eclipse.rcp feature was self-contained. In Eclipse 4 this is no longer true, since it requires org.eclipse.e4.rcp, plus two EMF features. The test can probably be refactored, but it is not a particularly important test case because it relates to using platform.xml with a MANAGED_ONLY policy which is a legacy update manager concept. I am just going to comment out the test with a comment pointing to this bug.

Comment 2 John Arthorne

2012-05-10 17:33:52 EDT

(In reply to comment #0)
> testBug238001    Failure    expected:<604> but was:<0>

This failure is caused by the new large icon, and IconExe failing to brand an RCP application using an ICO file that doesn't contain 256x256 icons. Bogdan is working on a fix for this, so it will be handy to have a regression test.

Comment 3 John Arthorne

2012-05-17 11:55:36 EDT

Arg, I made this change but forgot to commit.. too many things going on at once.

Comment 4 John Arthorne

2012-05-18 10:24:52 EDT

Pushed fix. Leaving open to check test results.

http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=8c831cfa3ec7440356d852d1c86e5fdbbf0f2537

Comment 5 John Arthorne

2012-05-22 16:49:36 EDT

This made it into RC1.

Comment 6 Valerio Santinelli

2012-08-03 03:45:49 EDT

Actually this test:

testBug183924	Error	Unable to find feature "org.eclipse.e4.rcp" with version in range [1.1.0.v20120131-1846-8yFTEFygGGduEKAaxP4Lpcqr,1.1.0.v20120131-1846-8yFTEFygGGduEKAaxP4Lpcqr]


is exactly the problem I'm experiencing when trying to export my 3.x based RCP application from Eclipse 4.2 
Is there any solution?

Comment 7 John Arthorne

2012-08-03 09:14:50 EDT

(In reply to comment #6)
> Actually this test:
> 
> testBug183924	Error	Unable to find feature "org.eclipse.e4.rcp" with version
> in range
> [1.1.0.v20120131-1846-8yFTEFygGGduEKAaxP4Lpcqr,1.1.0.v20120131-1846-
> 8yFTEFygGGduEKAaxP4Lpcqr]
> 
> 
> is exactly the problem I'm experiencing when trying to export my 3.x based
> RCP application from Eclipse 4.2 
> Is there any solution?

The reason for the error in the test case was that it attempted to export a feature (org.eclipse.rcp), without including its included features (org.eclipse.e4.rcp, org.eclipse.emf.ecore, etc). If you have this error, make sure all the feature inclusions are being included in the export. If your PDE target platform is pointing to Eclipse 3.x then your shouldn't have this problem. Maybe it's actually trying to export org.eclipse.rcp version 4.2 in your case?