Summary: | Always separate the Java Output Folder from the Java Source Folder | ||||||
---|---|---|---|---|---|---|---|
Product: | [WebTools] WTP Java EE Tools | Reporter: | Carl Anderson <ccc> | ||||
Component: | jst.j2ee | Assignee: | Carl Anderson <ccc> | ||||
Status: | RESOLVED FIXED | QA Contact: | Chuck Bridgham <cbridgha> | ||||
Severity: | normal | ||||||
Priority: | P1 | CC: | cbridgha, raghunathan.srinivasan, shr31223 | ||||
Version: | 3.3 | Flags: | ccc:
pmc_approved?
(david_williams) raghunathan.srinivasan: pmc_approved+ ccc: pmc_approved? (naci.dai) ccc: pmc_approved? (deboer) ccc: pmc_approved? (neil.hauge) ccc: pmc_approved? (kaloyan) raghunathan.srinivasan: pmc_approved? cbridgha: review+ |
||||
Target Milestone: | 3.4 M6 | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Whiteboard: | PMC | ||||||
Bug Depends on: | 287164 | ||||||
Bug Blocks: | 373663, 373136 | ||||||
Attachments: |
|
Description
Carl Anderson
2012-02-27 15:48:31 EST
Created attachment 211727 [details]
Use the default output directory in those cases
This does not change default behavior. However, if an adopter was relying on checks for ProductManager.shouldUseSingleRootStructure() to synchronize the source and output directories, they will no longer be in sync.
I ran the Java EE JUnit bucket against this patch. As expected, no test cases were effected. looks good PMC Review requested due to API change (behavior for adopters) Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. With Eclipse 3.8/4.2, due to the fix in bug 287164, if an adopter sets the ProductManager.shouldUseSingleRootStructure() preference, many of the project types that are created will show an error right after creation when the defaults are used. Is there a work-around? If so, why do you believe the work-around is insufficient? There is no workaround. How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? The Java EE JUnit bucket has been run against this change. The fix has been tested by hand both in WTP and in an adopter product that sets this flag. Give a brief technical overview. Who has reviewed this fix? Chuck Bridgham and Roberto Sanchez have reviewed this fix. The fix is to remove the check of the ProductManager.shouldUseSingleRootStructure() flag for those types, thus defaulting to build/classes as the java output folder. What is the risk associated with this fix? Medium-low... regular WTP users should be unaffected. Our concern is for adopters other than IBM that might be setting the ProductManager.shouldUseSingleRootStructure() flag. I'm voting for this one, because this should only affect adopters using the "singleRoot" preference (IBM) - and has no effect by default. Also important because of JDT recommended best practice Committed to HEAD for WTP 3.4.0 M6 |