Summary: | tycho-versions-plugin does not change version of the target platform configuration | ||
---|---|---|---|
Product: | z_Archived | Reporter: | Borislav Arnaudov <borislavarnaudov> |
Component: | Tycho | Assignee: | Jan Sievers <jan.sievers> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P2 | CC: | guillaume.duff, jan.sievers, sewe, simon.goodall |
Version: | unspecified | Keywords: | contributed, helpwanted |
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://git.eclipse.org/r/94263 https://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=75110302ffd9155f4e3a1dd84078f042313300b8 |
||
Whiteboard: |
Description
Borislav Arnaudov
2012-02-17 08:41:45 EST
This works for me with tycho 0.20.0, can you please retest? (In reply to Robert Munteanu from comment #1) > This works for me with tycho 0.20.0, can you please retest? I am not sure whether you are talking about the same thing. I think Borislav is talking about a POM like this one: <plugin> <groupId>org.eclipse.tycho</groupId> <artifactId>target-platform-configuration</artifactId> <configuration> <target> <artifact> <groupId>org.eclipse.recommenders.codesearch</groupId> <artifactId>luna</artifactId> <version>0.5.0-SNAPSHOT</version> </artifact> </target> </configuration> </plugin> (In reply to Andreas Sewe from comment #2) > (In reply to Robert Munteanu from comment #1) > > This works for me with tycho 0.20.0, can you please retest? > > I am not sure whether you are talking about the same thing. I think Borislav > is talking about a POM like this one: Sorry about the garbage; accidentally hit send. :-( <plugin> <groupId>org.eclipse.tycho</groupId> <artifactId>target-platform-configuration</artifactId> <configuration> <target> <artifact> <groupId>org.eclipse.recommenders.codesearch</groupId> <artifactId>luna</artifactId> <version>0.5.0-SNAPSHOT</version> </artifact> </target> </configuration> </plugin> Now, if you use mvn org.eclipse.tycho:tycho-versions-plugin:0.20.0:set-version -DnewVersion=0.6.0-SNAPSHOT to set the version of the luna artifact, the above plugin configuration (from the same reactor) is left untouched, even with Tycho 0.20.0 (just double-checked). Ah, ok. I did not see this because I use ${project.version} in my builds. (In reply to Robert Munteanu from comment #4) > Ah, ok. I did not see this because I use ${project.version} in my builds. Yes, in our case ${project.version} doesn't work as a workaround as that variable is expanded to the version of the child project, not the (different) version of the parent project (which configures the target-platform-configuration plugin). But defining a targetVersion property in the parent and then setting that as well with set-version using -Dproperties=targetVersion is a good-enough workaround. New Gerrit change created: https://git.eclipse.org/r/94263 @Guillaume thanks for proposing a patch! I will review as soon as I find some time but latest until end of this week Gerrit change https://git.eclipse.org/r/94263 was merged to [master]. Commit: http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/commit/?id=75110302ffd9155f4e3a1dd84078f042313300b8 @Guillaume thanks for the patch! |