Bug 371819

Summary: platform vs. dojo tooltips, accessibility labels
Product: [ECD] Orion (Archived) Reporter: Susan McCourt <susan>
Component: ClientAssignee: Susan McCourt <susan>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: maxli
Version: 0.4Keywords: accessibility
Target Milestone: 0.5 M1Flags: maxli: review?
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 365361    

Description Susan McCourt CLA 2012-02-16 16:53:06 EST
We have added various node titles, etc. for accessibility.
I noticed today that the action menu chevron now has double tooltips.  The browser tooltip as well as the dojo one.  I don't think we have this problem anywhere else.

Up in the banner, the user profile link and user menu chevron have browser tooltips.


So the questions are:
- can we have dojo tooltips for those top items and still be accessible?
- can we have just the dojo tooltip for the actions menu and be accessible?
- if we need to have the browser tooltips for accessibility, what should our strategy be for dojo vs. browser tooltips?  we should look at gmail, etc.
Comment 1 Max Li CLA 2012-02-17 14:39:12 EST
(In reply to comment #0)
> - can we have dojo tooltips for those top items and still be accessible?
I don't see a reason why we couldn't. They exist for the actions menu button (and I guess most (if not all) of the buttons in the UI) and those remain accessible.

> - can we have just the dojo tooltip for the actions menu and be accessible?
I would think so. The browser tooltip gets brought up from the title attribute on the button, but that doesn't get read by a screen reader (the aria-labelledby attribute directs what is read in this case). So by removing the title attribute, it should remove the tooltip without any adverse effect.
Comment 2 Max Li CLA 2012-02-22 16:21:55 EST
I took a stab at changing the all the browser tooltips to dojo tooltips. The buttons/links all seem to be accessible. In doing this, I had to also fix a couple of weird issues regarding the tooltips' accessibility.

I've put the commit here in the bug371819 branch.

https://github.com/max-li/orion.client/commit/f16400f9b9c9c2e0d8887ef118fb95a42c9d7bea
Comment 3 Susan McCourt CLA 2012-02-22 23:14:04 EST
thanks, Max, I'll look at this pretty quickly after we're done with 0.4
Comment 4 Susan McCourt CLA 2012-03-08 15:55:07 EST
pushed fix.  thanks, again, Max!