Summary: | Support for pre-release versions | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] PDE | Reporter: | Thomas Watson <tjwatson> | ||||||
Component: | UI | Assignee: | Curtis Windatt <curtis.windatt.public> | ||||||
Status: | RESOLVED FIXED | QA Contact: | |||||||
Severity: | normal | ||||||||
Priority: | P3 | CC: | curtis.windatt.public | ||||||
Version: | 3.8 | Keywords: | contributed | ||||||
Target Milestone: | 3.8 M5 | ||||||||
Hardware: | PC | ||||||||
OS: | Mac OS X - Carbon (unsup.) | ||||||||
Whiteboard: | |||||||||
Attachments: |
|
Description
Thomas Watson
2012-01-05 14:49:10 EST
Created attachment 209099 [details]
proposed fix
I'm still a loser when it comes to creating patches with eGit. Here is a patch I created with commandline git. Let me know if you have trouble applying it.
Created attachment 209154 [details]
Updated patch
I went back and had OSGi update the org.osgi.framework.VersionRange class to not include fully qualified versions in VersionRange.toString() unless they are required.
This is an updated patch that takes advantage of that instead of having our own code to print version ranges. The other changes are still required to avoid displaying fully qualified versions in the dialog for uses to enter in version information unless needed.
BTW the new VersionRange from OSGi was committed to master with: http://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=80cf0452e3b3c7c425f334a1ee1e361a809008d2 When do you see the extra info getting put into the manifest? I can see it in editor (PluginVersionPart), but I don't see any changes being made to the manifest text. The contributed patch corrects the problems that I did see in the UI. I have pushed it to master. |