Bug 360317

Summary:	[compiler] report switch over enum in 1.4- mode
Product:	[Eclipse Project] JDT	Reporter:	Stephan Herrmann <stephan.herrmann>
Component:	Core	Assignee:	Stephan Herrmann <stephan.herrmann>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	srikanth_sankaran
Version:	3.8
Target Milestone:	3.8 M3
Hardware:	Other
OS:	Linux
Whiteboard:
Bug Depends on:	360164
Bug Blocks:

Description Stephan Herrmann

2011-10-08 09:26:53 EDT

The test case attached in bug 360164 comment 21 shows that if we allow 
resolving binary enum types even in 1.4- mode we would end up allowing 
switch over enum also below 1.5.

I believe the same was also true before bug 349326. Only with bug 349326
is the code currently rejected due to missing superclass Enum.

While it is technically possible to compile such code for a J2SE-1.4
this still looks wrong as we're accepting code that a 1.4 compiler could not.

Comment 1 Srikanth Sankaran

2011-10-14 03:44:13 EDT

(In reply to comment #0)
> The test case attached in bug 360164 comment 21 shows that if we allow 
> resolving binary enum types even in 1.4- mode we would end up allowing 
> switch over enum also below 1.5.
> 
> I believe the same was also true before bug 349326

Yes, Just to be sure, I confirmed it with 3.6.2

> While it is technically possible to compile such code for a J2SE-1.4

What did you mean by that ? 

> this still looks wrong as we're accepting code that a 1.4 compiler could not.

Yes, I'll post a patch shortly at bug 360164

Comment 2 Stephan Herrmann

2011-10-18 07:11:40 EDT

(In reply to comment #1)
> Yes, I'll post a patch shortly at bug 360164

The new message reads:

  Cannot switch on a value of type enum for source level below 1.5

Nit-picking: "enum" is not a type.

For comparison message 881 reads:

  Only convertible int values or enum variables are permitted

(why "variable"?)

How about:
  Cannot switch on an enum value for source level below 1.5
or 
  Cannot switch on a value of an enum type for source level below 1.5
?

Comment 3 Srikanth Sankaran

2011-10-18 09:22:44 EDT

(In reply to comment #2)
> (In reply to comment #1)

> How about:
>   Cannot switch on an enum value for source level below 1.5
> or 
>   Cannot switch on a value of an enum type for source level below 1.5
> ?

Reconciling the above with bug 360164 comment 36, let us settle on:

Cannot switch on an enum value for source level below 1.5.  Only 
convertible int values are permitted

Comment 4 Stephan Herrmann

2011-10-18 10:38:05 EDT

Released as commit 2d89f0516f5e5910bcd18015e8090ed0805dbb4e for 3.8 M3.
(combined patch with bug 360164).

Comment 5 Srikanth Sankaran

2011-10-24 04:25:47 EDT

Verified for 3.8 M3 using build id: N20111022-2000.