Bug 359727

Summary: [1.7][doc] Update doc for new resource leak warnings
Product: [Eclipse Project] JDT Reporter: Ayushman Jain <amj87.iitr>
Component: CoreAssignee: Stephan Herrmann <stephan.herrmann>
Status: VERIFIED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: amj87.iitr, deepakazad, markus.kell.r, Olivier_Thomann, srikanth_sankaran, stephan.herrmann
Version: 3.7   
Target Milestone: 3.8 M3   
Hardware: Other   
OS: Linux   
Whiteboard:
Bug Depends on: 349326    
Bug Blocks:    
Attachments:
Description Flags
doc-update none

Description Ayushman Jain CLA 2011-10-03 11:47:25 EDT
Fup of Bug #349326

The o.e.jdt.doc.isv/guide/jdt_api_options.htm page needs to be updated with the new resource leak warning options from bug 349326. 

Stephan, you can do this at your convenience. This needs to be done before 3.8M3 though so I will take over if you're short on time.
Comment 1 Ayushman Jain CLA 2011-10-12 10:50:51 EDT
Also, the buildnotes should contain an entry for the new JavaCore API that was introduced.
Comment 2 Stephan Herrmann CLA 2011-10-18 05:58:01 EDT
Created attachment 205404 [details]
doc-update

Here's the requested update for jdt_api_options.htm.

I wasn't 100% sure about the sorting in that file, so here's what I did:
- alphabetically sort in "Report Unclosed Closeable"
- insert related options directly after

Hope that's OK.
Comment 3 Stephan Herrmann CLA 2011-10-18 06:42:36 EDT
jdt_api_options.htm has been committed to CVS.

(In reply to comment #1)
> Also, the buildnotes should contain an entry for the new JavaCore API that was
> introduced.

Done as part of
commit 86113d82738e778f8e0f07729ab352d227a867ad for 3.8 M3.
Comment 4 Deepak Azad CLA 2011-10-18 06:57:05 EDT
(In reply to comment #3)
> jdt_api_options.htm has been committed to CVS.
CVS ? See bug 360157.
Comment 5 Ayushman Jain CLA 2011-10-18 07:08:15 EDT
(In reply to comment #4)
> (In reply to comment #3)
> > jdt_api_options.htm has been committed to CVS.
> CVS ? See bug 360157.

Is the migration complete? The bus isn't closed yet.
Comment 6 Stephan Herrmann CLA 2011-10-18 07:18:04 EDT
I also noticed that the doc bundle hasn't been updated in the latest 
I-build so the API reference doesn't yet contain the new constants.
Is there something I need to do to trigger rebuilding that, too?
Comment 7 Deepak Azad CLA 2011-10-18 07:23:21 EDT
Well, bug 360157 comment 8 is pretty clear that the migration is done, unless there is something wrong with the repo and migration needs to be done again. Hence, the changes should be done in Git.

Markus, do you have anything to add?
Comment 8 Stephan Herrmann CLA 2011-10-18 07:58:20 EDT
(In reply to comment #7)
> Well, bug 360157 comment 8 is pretty clear that the migration is done, unless
> there is something wrong with the repo and migration needs to be done again.
> Hence, the changes should be done in Git.

Done, commit 649066da54acfb46f4c8738daaaa1fbc2c532bd8
Comment 9 Ayushman Jain CLA 2011-10-24 15:53:35 EDT
Verified using build N20111022-2000.