Bug 357259

Summary: [dom] AST#newArrayType(Type, int) should allow array type as argument
Product: [Eclipse Project] JDT Reporter: Markus Keller <markus.kell.r>
Component: CoreAssignee: Markus Keller <markus.kell.r>
Status: VERIFIED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: markus.kell.r, Olivier_Thomann, srikanth_sankaran
Version: 3.8Flags: Olivier_Thomann: review+
Target Milestone: 3.8 M2   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Fix
none
Proposed fix + regression test none

Description Markus Keller CLA 2011-09-09 12:19:23 EDT 
Created attachment 203074 [details]
Fix

HEAD

AST#newArrayType(Type, int) should allow an array type as argument. The current API is just inconvenient for no good reason.

The patch also removes bogus
     * <li>a cycle in would be created</li>
from Javadocs.
Comment 1 Markus Keller CLA 2011-09-09 12:33:01 EDT 
OK for M2? I'd like to use this for bug 89432.
Comment 2 Olivier Thomann CLA 2011-09-09 12:47:04 EDT 
Patch looks good. I didn't run the tests, but I will.
I would just replace:
	 * @param elementType the element type (can an array type)
with:
	 * @param elementType the element type (can be an array type)
Comment 3 Markus Keller CLA 2011-09-09 13:10:03 EDT 
Released for 3.8M2, including the grammar fix.
Comment 4 Olivier Thomann CLA 2011-09-09 13:13:04 EDT 
Created attachment 203079 [details]
Proposed fix + regression test

Fix the typo and add regression test.
Comment 5 Srikanth Sankaran CLA 2011-09-13 04:20:07 EDT 
Verified for 3.8M2 via inspection of code and tests.
Comment 6 Markus Keller CLA 2011-09-13 09:32:27 EDT 
The code has been committed to HEAD, but unfortunately, it has not been released into the build.
Comment 7 Olivier Thomann CLA 2011-09-13 09:52:07 EDT 
The entry was missing in the buildnotes. I'll tag it for next I-build.
Comment 8 Olivier Thomann CLA 2011-09-13 10:08:05 EDT 
Map file is updated for next build. Thanks Markus for letting us know.