Bug 35356

Summary:	Convert local variable to field refactoring proposes weird name
Product:	[Eclipse Project] JDT	Reporter:	Oyvind Harboe <oyvind.harboe>
Component:	Core	Assignee:	David Audel <david_audel>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	akiezun, dberindei, dcorbin, eclipse, markus.kell.r, nikolaymetchev, preuss
Version:	2.1
Target Milestone:	3.0 M9
Hardware:	PC
OS:	Windows 2000
Whiteboard:

Description Oyvind Harboe

2003-03-20 07:56:49 EST

- "Convert local variable to field" on "colorNames"
- The name proposed is "nameses"
- No exceptions in log
- Eclipse RC2


public class Foo
{
	public void bar()
	{
		String[] colorNames={"red","green", "blue"};
	}
}

Comment 1 Dirk Baeumer

2003-03-20 09:36:33 EST

Adam, do we use core functionality for name proposing in this case ?

Comment 2 Adam Kiezun

2003-03-20 09:41:04 EST

yes, seems like NamingConventions problem

Comment 3 Oyvind Harboe

2003-03-21 06:52:19 EST

I think this behaviour is new since RC2, I can't remember bumping into the 
problem earlier. 

Øyvind

Comment 4 Adam Kiezun

2003-03-21 06:55:02 EST

yes, we moved to using the NamingConventions class for M3 or a bit later

Comment 5 Ilja Preuss

2003-07-11 03:52:43 EDT

I don't understand why this refactoring doesn't just leave the variable name as 
it is...?

Comment 6 Adam Kiezun

2003-07-11 04:59:16 EDT

normally people have conventions for instance field names,
so their names would start with '_' or 'f' or something

so if you have a temp named colorNames, and your pref set to 'f' prefix for 
field names, the refactoring should suggest 'fColorNames' as the field name

Comment 7 David Corbin

2003-11-25 18:55:55 EST

some people have name convention for fields.  Some of us hate such standards and
avoid it like the plague. 

Regardless, changing the "launcherLabel" to "label" doesn't make sense.

Comment 8 David Audel

2004-05-13 04:50:51 EDT

New naming conventions.
If it is an array type
  which ends with "ss" then append "es"
  which ends with "y" then remove "y" and append "ies"
  which ends with "s" do nothing
  otherwise append "s"

Fixed end tests added
  NamingConventions#testSuggestFieldName017
  NamingConventions#testSuggestFieldName018
  NamingConventions#testSuggestFieldName019
  NamingConventions#testSuggestFieldName020

Comment 9 Ilja Preuss

2004-05-13 05:04:06 EDT

So, what does happen to colorNames, now? "names" or "colorNames"? In my humble 
opinion, the latter would make more sense...

Comment 10 David Audel

2004-05-13 05:10:33 EDT

NamingConventions propose "colorNames" and "names". Convert local variable to 
field refactoring must choose only one name and currently it is "colorNames".

Comment 11 Ilja Preuss

2004-05-13 05:18:45 EDT

Nice, thanks!

Comment 12 Nikolay Metchev

2004-05-13 07:58:37 EDT

Those rules are good but only if you are coding in english. Not that I am 
coding in any other language but just a thought.

Comment 13 Markus Keller

2004-05-13 08:31:48 EDT

Re comments 7, 9, and 10: those issues have been resolved with bug 54444.

Comment 14 Olivier Thomann

2004-05-18 11:01:05 EDT

Verified in 200405180816