Summary: | [server] Git tests fail on Linux because of NPE in InternalFileSystemCore | ||
---|---|---|---|
Product: | [ECD] Orion (Archived) | Reporter: | Tomasz Zarna <tomasz.zarna> |
Component: | Client | Assignee: | John Arthorne <john.arthorne> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | john.arthorne, Szymon.Brandys, tomasz.zarna |
Version: | 0.2 | Keywords: | test |
Target Milestone: | 0.2 | ||
Hardware: | PC | ||
OS: | Linux | ||
URL: | http://download.eclipse.org/e4/orion/drops/N201104012000/org.eclipse.orion.server.tests.AllServerTests.html | ||
Whiteboard: |
Description
Tomasz Zarna
2011-04-04 05:57:54 EDT
John, shouldn't InternalFileSystemCore.getFileSystem(String) throw a CoreException when scheme is null? This is what I would expect calling EFS.getFileSystem(String) and it looks like you expect it as well in WorkspaceResourceHandler.computeProjectLocation(WebProject, String, String, boolean) having "} catch (CoreException e) {" clause. (In reply to comment #1) > John, shouldn't InternalFileSystemCore.getFileSystem(String) throw a > CoreException when scheme is null? This is what I would expect calling > EFS.getFileSystem(String) and it looks like you expect it as well in > WorkspaceResourceHandler.computeProjectLocation(WebProject, String, String, > boolean) having "} catch (CoreException e) {" clause. No. NPE is right there. If method does not say clearly that null can be pased, you should not pass 'null' to the method. (In reply to comment #2) > No. NPE is right there. If method does not say clearly that null can be pased, > you should not pass 'null' to the method. It should be handled in WorkspaceResourceHandler#computeProjectLocation. I'll take this since it looks like I broke it. http://git.eclipse.org/c/e4/org.eclipse.orion.server.git/commit/?id=b82d5e6f4c6abad3044ebe66c9bae95333a95e58 Fix released, and Andrew verified on Linux that all tests now pass. |