Bug 339572

Summary: [NLS] Superfluous "(Java EE 6)" in the EJB Timer wizard action
Product: [WebTools] WTP EJB Tools Reporter: Kaloyan Raev <kaloyan>
Component: jst.ejbAssignee: ludo <ludo>
Status: RESOLVED FIXED QA Contact: Kaloyan Raev <kaloyan>
Severity: normal    
Priority: P3 CC: cbridgha
Version: 3.3Keywords: PII
Target Milestone: 3.3 M7Flags: kaloyan: pmc_approved? (david_williams)
kaloyan: pmc_approved? (raghunathan.srinivasan)
kaloyan: pmc_approved? (naci.dai)
kaloyan: pmc_approved? (deboer)
kaloyan: pmc_approved? (neil.hauge)
kaloyan: pmc_approved? (kaloyan)
cbridgha: pmc_approved+
kaloyan: review+
Hardware: PC   
OS: Windows Vista   
Whiteboard: PMC_approved
Attachments:
Description Flags
proposed patch kaloyan: iplog+

Description Kaloyan Raev CLA 2011-03-10 14:11:17 EST 
The New EJB Timer wizard action is labeled as "EJB Timer (Java EE 6)". IMHO, this "(Java EE 6)" is not necessary, because EJB Timers are introduced in Java EE 6 and they are not available in previous versions of the spec. 

I suggest to remove it to keep the labels of the EJB artifact actions consistent.
Comment 1 Kaloyan Raev CLA 2011-04-21 11:10:06 EDT 
Ludo, since you are the contributor of this feature, could you work on proposing a patch for this issue?
Comment 2 ludo CLA 2011-04-21 11:38:30 EDT 
Created attachment 193853 [details]
proposed patch

agree. See the patch.
Comment 3 Kaloyan Raev CLA 2011-04-26 04:17:29 EDT 
    Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

The support for EJB Timers has been introduced with M6. This patch fixes a small UI inconsistency. It's good to fix it now - before the first release of WTP that introduces this new feature. 

    Is there a work-around? If so, why do you believe the work-around is insufficient? 

No.

    How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Manually tested. 

    Give a brief technical overview. Who has reviewed this fix? 

This is a simple change in a text label. 

    What is the risk associated with this fix? 

No risk.
Comment 4 Chuck Bridgham CLA 2011-04-26 10:29:30 EDT 
I'm ok with this
Comment 5 Kaloyan Raev CLA 2011-04-26 10:54:51 EDT 
Comitted and released to HEAD