Summary: | Target definition editor location section losing content | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] PDE | Reporter: | Eckart Langhuth <eckart.langhuth> | ||||||||
Component: | UI | Assignee: | Curtis Windatt <curtis.windatt.public> | ||||||||
Status: | RESOLVED FIXED | QA Contact: | |||||||||
Severity: | normal | ||||||||||
Priority: | P3 | CC: | curtis.windatt.public, jeffmcaffer | ||||||||
Version: | 3.7 | Keywords: | contributed | ||||||||
Target Milestone: | 3.7 M6 | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows 7 | ||||||||||
Whiteboard: | |||||||||||
Attachments: |
|
Description
Eckart Langhuth
2011-02-28 08:15:07 EST
Created attachment 189938 [details]
Screenshots
Created attachment 189939 [details]
patch proposal
Jeff, can you take a look at this? Just saw this bug now. I will take a look later today. Created attachment 190335 [details]
revised patch
The fix approach looks good. I tweaked it a bit to put the mark dirty call in IUBundleContainer.associateWithTarget() rather than in TargetDefinition. That keeps TargetDefinition clean of particulars of various containers. It means that markDirty() will be called once for each IU container but the call is just a field set so its not a big deal.
I tested that it did indeed address the problem (thanks btw)
I assume that the jdt pref changes are incidental, so this is just a one line fix. Fixed in HEAD. Thanks for the contribution! yes, the pref change was incidental. Needed to do it to make the build system happy as I don't have a 1.4 VM. Interestingly when I generated the patch I deselected that change so assumed it would not show up in the patch. Go figure. Thanks for taking care of this. |