Bugzilla – Full Text Bug Listing
| Summary: | testFileMoveAndCopy, testFolderMoveAndCopy and testBug62547 failed | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Tomasz Zarna <tomasz.zarna> | ||||||||||
| Component: | CVS | Assignee: | Malgorzata Janczarska <malgorzata.tomczyk> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P2 | CC: | daniel_megert, Szymon.Brandys | ||||||||||
| Version: | 3.7 | Keywords: | test | ||||||||||
| Target Milestone: | 3.7 M6 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | All | ||||||||||||
| URL: | http://fullmoon.ottawa.ibm.com/downloads/drops/N20110207-2000/testresults/html/org.eclipse.team.tests.cvs.core_win32.win32.x86_6.0.html | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Tomasz Zarna
And there are 2 more failures in N20110207-2000. Can we please fix this asap. We need to get back to a state where we have builds without failures. Thanks. (In reply to comment #1) > And there are 2 more failures in N20110207-2000. See bug 246547 for failure in testImportMultipleProjects and bug 325553 for testCacheBase. Created attachment 188657 [details]
Fix for tests
This patch fixes tests. The fixes are as follows:
1. one test included too large precision of modification date for Linux
2. two other tests failed when cvs server return any additional information, in this case on level info although the operation was successful.
It appears that testFileMoveAndCopy() would have warned us about bug 62547 if assertModificationState had been called for both files after copying the destination back to the source without a commit in the meantime (line 360). Gosia could you please verify this? (In reply to comment #4) > It appears that testFileMoveAndCopy() would have warned us about bug 62547 if > assertModificationState had been called for both files after copying the > destination back to the source without a commit in the meantime (line 360). > Gosia could you please verify this? That's correct, the file was moved from it's original place and then moved back to it. Before bug 62547 was fixed the file was reported as unchanged, although there were some actions on it in meantime. However its content did not change, so information that the file in unchanged is not far from trough. That's why I added testBug62547: the file content changes in meantime and there is no doubt that file should be reported as changed. The fix is fine, I would add a few tweaks: * simply rethrow an exception if it indicates an error * add the missing files to assertModificationState check in testFileMoveAndCopy(), not sure if the other test is missing them too * can we avoid "Decreasing precision" hack in testBug62547, by simply getting a timestamp from one file and setting it on the other, without calling System.currentTimeMillis()? * try to use the same helper methods in your test as in the others, this will make reading the tests easier in the future Created attachment 188762 [details]
Corrected tests
Tomek's comments applied.
Created attachment 188828 [details] Corrected tests v02 (In reply to comment #7) > * add the missing files to assertModificationState check in > testFileMoveAndCopy(), not sure if the other test is missing them too You missed that in your patch. I modified assertions in testFileMoveAndCopy and testFolderMoveAndCopy. I also simplified the test in testBug62547 a little bit. Created attachment 188829 [details]
mylyn/context/zip
The latest patch has been applied to HEAD. Available in build >=N20110212-2000. |