Bug 332451

Summary: Javadoc cleanup in SearchEngine#createJavaSearchScope(IJavaElement[], int)
Product: [Eclipse Project] JDT Reporter: Markus Keller <markus.kell.r>
Component: CoreAssignee: Olivier Thomann <Olivier_Thomann>
Status: VERIFIED FIXED QA Contact:
Severity: trivial    
Priority: P3 CC: amj87.iitr, Olivier_Thomann
Version: 3.7   
Target Milestone: 3.7 M5   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
Proposed fix
none
Fix 2 none

Description Markus Keller CLA 2010-12-13 11:31:38 EST
HEAD

Javadoc of SearchEngine#createJavaSearchScope(IJavaElement[], int) needs some cleanup:
- formatting needs to be HTML
- should reference {@link IJavaSearchScope#SYSTEM_LIBRARIES} here:
	 * - its system libraries (internal and external jars, class folders that are coming from an
	 *   IClasspathContainer with the K_SYSTEM kind)
	 *   if IJavaSearchScope.APPLICATION_LIBRARIES is specified

The other createJavaSearchScope(..) methods would also be easier to read with a few more <p>s or <br>s.
Comment 1 Olivier Thomann CLA 2010-12-16 09:25:07 EST
Created attachment 185321 [details]
Proposed fix
Comment 2 Olivier Thomann CLA 2010-12-16 09:25:45 EST
Released for 3.7M5.
Markus, let me know if this is what you wanted. It looks at least much better now.
Comment 3 Markus Keller CLA 2010-12-16 10:47:28 EST
Created attachment 185331 [details]
Fix 2

Formatting looks good, but the wrong reference to APPLICATION_LIBRARIES is still there.
Comment 4 Markus Keller CLA 2010-12-16 10:47:45 EST
.
Comment 5 Olivier Thomann CLA 2010-12-16 10:52:38 EST
Released. Thx. I misunderstood your comment 0.
Comment 6 Ayushman Jain CLA 2011-01-25 08:21:41 EST
Verified for 3.7M5 using code inspection.