Bugzilla – Full Text Bug Listing
| Summary: | Refactoring [427]: Remove Assigned Goto - CQ Approved | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] PTP | Reporter: | John Hammonds <hammonds.john9> | ||||
| Component: | Photran.Refactoring Engine | Assignee: | Jeffrey Overbey <com-eclipse-dot-org> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P1 | CC: | a.merry.giraffe, com-eclipse-dot-org, hammonds.john9, paramvir.singh, rajashekharma, rockmylife | ||||
| Version: | 6.0 | ||||||
| Target Milestone: | 7.0 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Hi all, Thanks for the contribution! The patch looks good; I don't believe any further changes are necessary at this time. Before we submit this for an IP review, can the five of you *each* please confirm that 1. you wrote 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. you have the right to contribute the code to Eclipse, and 3. you have included the EPL license header in all source files? Thanks! Jeff (In reply to comment #1) This is to confirm that we have: 1. Contributed 100% of the content. 2. We have the right to contribute the code. 3. Included the EPL header in all source files. Thanks, John. Andrea, Rajashekhar, Balaji, and Paramvir, I need to ask you to make similar confirmations... (In reply to comment #1) This is to confirm that 1. We have written 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. We have the right to contribute the code to Eclipse, and 3. We have included the EPL license header in all source files. This is to confirm that 1. We have written 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. We have the right to contribute the code to Eclipse, and 3. We have included the EPL license header in all source files. This is to confirm that 1. We have written 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. We have the right to contribute the code to Eclipse, and 3. We have included the EPL license header in all source files. This is to confirm that 1. We have written 100% of the code without incorporating content from elsewhere or relying on the intellectual property of others, 2. We have the right to contribute the code to Eclipse, and 3. We have included the EPL license header in all source files. Thanks for the quick replies! I'll start the IP review process soon. If the IP team has any questions, I'll post them here. For the IP review, I will need to describe how much of the work was done by each person involved. Generally, for CS427 projects, the work was more-or-less evenly distributed, so I will use the following breakdown unless you inform me otherwise: Andrea Dranberg - 20% John Hammonds - 20% Rajashekhar Arasanal - 20% Balaji Ambresh Rajkumar - 20% Paramvir Singh - 20% (In reply to comment #9) Given the nature of the class project, I think that this split is appropriate. CQ 4703 Submitted - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=4703 The CQ was approved. Check in to CVS pending. These are committed to CVS HEAD for inclusion in Photran 7.0/Indigo (the June, 2011 release). Thanks again for the contribution! Please also make sure your names are all included and are spelled correctly on the Contributors page: http://www.eclipse.org/photran/contributors.php |
Created attachment 184839 [details] Patch file created against CVS @ 6:55PMCST 2010-12-8 This refactoring will • Replace instances of ASSIGN statements with assignment statements. • Replace assigned GOTO statements with SELECT CASE statements with nested (normal) GOTOs. Refactoring of a particular ASSIGN or assigned GOTO will fail if • The statement label used in an ASSIGN is not present in the scoping unit of the ASSIGN statement. • The variable name associated with the ASSIGN statement is used in an action statement. The user will be presented with a graphical interface to select if a default CASE statement should be added to the SELECT CASE in the refactored output. If multiple variables are specified by assign statements • If all of the labels are used in action statements, the refactoring will fail • If some of the labels are used in an action statement, the user will be prompted to decide if the refactoring should continue refactoring only the cases where the variable is not used in an action statement. A hot key is added to launch the refactoring. The hot key is assigned to Alt+Shift+A.