Bug 332041

Summary: Backport bug 162079: [PropertiesView] Properties view should be a post selection listener
Product: [Eclipse Project] Platform Reporter: Dani Megert <daniel_megert>
Component: UIAssignee: Dani Megert <daniel_megert>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: adamneal, bokowski, emoffatt, markus.kell.r, remy.suen, thatnitind
Version: 3.3Keywords: performance
Target Milestone: 3.6.2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Fix
none
Fix none

Description Dani Megert CLA 2010-12-07 11:15:20 EST 
3.3.

This is to cover the backport of the fix for bug 162079.
Comment 1 Dani Megert CLA 2010-12-07 11:32:08 EST 
Created attachment 184729 [details]
Fix
Comment 2 Dani Megert CLA 2010-12-07 11:33:21 EST 
Boris, there was a request to backport this. The fix is very small and the risk is very low.

Please take a look at the attached patch which also fixes some bad tests.
Comment 3 Dani Megert CLA 2010-12-07 12:00:35 EST 
Boris, please hold off with a review. It seems the fix needs some more polish.
Comment 4 Dani Megert CLA 2010-12-08 07:50:03 EST 
Created attachment 184778 [details]
Fix
Comment 5 Dani Megert CLA 2010-12-13 06:21:33 EST 
Boris, the patch is now ready for review.
Comment 6 Boris Bokowski CLA 2011-01-09 22:41:03 EST 
+1 for 3.6.2.

Unlike comment 2, I wouldn't say that the risk is very low since we're changing (well, fixing) selection event processing. However, the benefit is a substantial performance improvement for those who use arrow keys in trees when page book views are open (i.e., all the time).

Eric, could you please spend some extra time trying to find if there's a problem with this that we haven't seen so far?
Comment 7 Dani Megert CLA 2011-01-10 05:49:43 EST 
Committed the patch to 'R3_6_maintenance' with updated copyright dates and correct bundle versions for the branch.