Bug 3310

Summary:	Smoke 124: Compile errors introduced with rename refactoring (1GFBK2G)
Product:	[Eclipse Project] JDT	Reporter:	Dani Megert <daniel_megert>
Component:	Core	Assignee:	Jerome Lanneluc <jerome_lanneluc>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	P2
Version:	2.0
Target Milestone:	2.0 M1
Hardware:	All
OS:	All
Whiteboard:

Description Dani Megert

2001-10-10 22:53:00 EDT

1. Create new Java Project with Junit
	2. In Packages view: rename TestCase.java to Test$Case.java
		==> OK
	2. Now rename it back to TestCase.java
	==> Compile errors


NOTES:

AK (6/14/01 6:45:31 PM)
	warning is correctly prosented 
	searching for all occurrences of Test$Case fails to find any
	refactoring code cannot do anything in that case

	suggest to not fix now - corner case
	and undo works fine
	
AK (8/15/2001 12:31:04 PM)
	moving to jcore for comment on why no occurrences of Test$Case are found

JBL (9/26/2001 6:10:06 PM)
	Problem is that the search pattern created from the java element Test$Case is wrong.
	It assumes that the $ is a type separator and it creates a TypeReferencePattern
	with a 'Case'  simple name, and 'Test' enclosing type name.
	Need to rewrite createTypePattern(...)

Comment 1 Jerome Lanneluc

2001-10-16 06:24:55 EDT

Rewrote createTypePattern(...) to handle the $ case.
Also needed to fix NameLookup.seekTypesInSourcePackage(...) as this was also 
considering that the type Test$Case was included in the Test.java compilation 
unit.

Comment 2 Jerome Lanneluc

2001-10-16 06:40:42 EDT

Added JavaSearchTests.testTypeOccurenceWithDollar()

Comment 3 DJ Houghton

2001-10-29 17:08:34 EST

PRODUCT VERSION:
	Smoke 124 i.e. build input 1 for 0.124