Summary: | [Model] Possible bug in Member class | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Jeff McAffer <jeffmcaffer> | ||||
Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | jarthana, Olivier_Thomann | ||||
Version: | 3.7 | Flags: | jarthana:
review+
|
||||
Target Milestone: | 3.7 M4 | ||||||
Hardware: | PC | ||||||
OS: | Mac OS X - Carbon (unsup.) | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Jeff McAffer
2010-11-22 14:05:01 EST
Thanks, Jeff. This is indeed a bug. I guess you meant: boolean isParameter = Boolean.valueOf(memento.nextToken()).booleanValue(); I'll provide a patch shortly. Created attachment 183598 [details]
Proposed fix + regression test
Changing the MementoTests to check that the memento of the restored java element is equals to the expected memento.
I think this also exposed a bug in org.eclipse.jdt.internal.core.JavaProject.getPackageFragmentRoot(IPath).
See attached patch.
Jay, please review the patch. I have not yet run all tests with this patch. But MementoTests are now green. All model tests passed. Patch looks good. Released for 3.7M4. Verified for 3.7M4 by code inspection and regression tests. |