Summary: | Support ResolverHook during build | ||
---|---|---|---|
Product: | [Eclipse Project] PDE | Reporter: | Stephan Herrmann <stephan.herrmann> |
Component: | Build | Assignee: | pde-build-inbox <pde-build-inbox> |
Status: | RESOLVED WONTFIX | QA Contact: | |
Severity: | enhancement | ||
Priority: | P3 | CC: | aniefer, gunnar, tjwatson |
Version: | 3.7 | ||
Target Milestone: | --- | ||
Hardware: | Other | ||
OS: | All | ||
Whiteboard: |
Description
Stephan Herrmann
2010-11-21 18:52:25 EST
My biggest concern would be relying on internals to initialize this. Are there any default ResolverHooks that would change the behaviour when running with a normal SDK or releng.basebuilder? (In reply to comment #1) > My biggest concern would be relying on internals to initialize this. You mean the necessity to call StateImpl.setResolverHookFactory() ? > Are there any default ResolverHooks that would change the behaviour when > running with a normal SDK or releng.basebuilder? At this point I don't know about any implementations of ResolverHook (aside from the delegating CoreResolverHookFactory). I assume that as soon as (more) people use the new API some will eventually need consistent support also during build. But given that bug 330534 no longer depends on this RFE I personally wouldn't mind if you close as WONTFIX. (In reply to comment #2) > (In reply to comment #1) > > My biggest concern would be relying on internals to initialize this. > > You mean the necessity to call StateImpl.setResolverHookFactory() ? > This, and that CoreResolverHookFactory itself is also internal. We can see what Tom says about this, I believe he is on vacation this week. I do not want to expose this hook for the State at this point. I would prefer to keep the setting of the resolver hook in the state as an internal detail for now. (In reply to comment #4) > I do not want to expose this hook for the State at this point. I would prefer > to keep the setting of the resolver hook in the state as an internal detail for > now. Alright, in that case and given that the original motivation has gone, I'm withdrawing this RFE for now. |