Bug 328020

Summary:	[nls tooling] Allow to open NLS wizard on package and properties file
Product:	[Eclipse Project] JDT	Reporter:	Dani Megert <daniel_megert>
Component:	Text	Assignee:	JDT-Text-Inbox <jdt-text-inbox>
Status:	ASSIGNED ---	QA Contact:
Severity:	enhancement
Priority:	P3
Version:	3.6
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Dani Megert

2010-10-18 05:22:46 EDT

3.6.

We should allow to open the NLS wizard on a package and a properties file. Currently a CU is required for that.

The question is whether we only allow to edit the values. Otherwise we also need to find and update the affected CUs which might become tricky.

Comment 1 Deepak Azad

2010-10-19 13:52:02 EDT

Currently if you select a package and invoke the 'Source > Externalize Strings...' action, a dialog showing all CUs with non-externalized strings comes up. This bug is for getting rid of this dialog and letting the Externailze Strings wizard act on all the CUs together ?

Comment 2 Dani Megert

2010-10-20 03:19:03 EDT

(In reply to comment #1)
> Currently if you select a package and invoke the 'Source > Externalize
> Strings...' action, a dialog showing all CUs with non-externalized strings
> comes up. This bug is for getting rid of this dialog and letting the
> Externailze Strings wizard act on all the CUs together ?
No, I don't want to change that workflow.

What this bug is about is that we allow to edit the properties file via wizard even if there's no non-externalized string. The wizard has the advantage of being WYSIWYG.

Comment 3 Deepak Azad

2010-10-20 04:24:10 EDT

Ok, I see.

(In reply to comment #0)
> The question is whether we only allow to edit the values. Otherwise we also
> need to find and update the affected CUs which might become tricky.
You can still run into this problem if you uncheck the 'Filter all existing ignored and externalized strings' option in the wizard and then modify an existing key.

(In reply to comment #2)
> The wizard has the advantage of being WYSIWYG.
Minor point: Currently in the wizard value column is on the left, in the properties editor values are on the right. Re-ordering the columns in the wizard to match the editor could be an option.

Comment 4 Dani Megert

2010-10-20 04:26:57 EDT

> > The question is whether we only allow to edit the values. Otherwise we also
> > need to find and update the affected CUs which might become tricky.
> You can still run into this problem if you uncheck the 'Filter all existing
> ignored and externalized strings' option in the wizard and then modify an
> existing key.
We could have a 'mode' where the wizard would show all entries and only allows to change the values.

> (In reply to comment #2)
> > The wizard has the advantage of being WYSIWYG.
> Minor point: Currently in the wizard value column is on the left, in the
> properties editor values are on the right. Re-ordering the columns in the
> wizard to match the editor could be an option.
Yes.