Bug 325163

Summary:

Link (Edge) distorted after upgrading GMF versions

Product:

[Modeling] GMF-Runtime

Reporter:

Shilpa Toraskar <storaskar>

Component:

General

Assignee:

Alex Boyko <aboyko>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

aboyko, ahunter.eclipse, bxu, lgrahek, xiaodic

Version:

2.2.2

Target Milestone:

1.4.2

Hardware:

OS:

Windows XP

Whiteboard:

2.2.3 Patch

Attachments:

Description	Flags
result use old GMF	none
result use new GMF	none
The patch for this issue	none

Description Shilpa Toraskar

2010-09-13 16:36:51 EDT

We have lot of diagrams with links (edges) in them connecting two nodes. The links were straight before but after the upgrade to newer GMF versions, those are distorted. Seems like Source and target anchor points are positioned/calculated differently.

We upgraded from 1.0.x to 2.2.x. So it's quite a jump.

Comment 1 Alex Chen

2010-09-29 04:26:54 EDT

Created attachment 179811 [details]
result use old GMF

Comment 2 Alex Chen

2010-09-29 04:27:25 EDT

Created attachment 179812 [details]
result use new GMF

Comment 3 Alex Chen

2010-09-29 04:28:46 EDT

This bug was introduced on 1.4 version of class org.eclipse.gmf.runtime.draw2d.ui.figures.BaseSlidableAnchor.

I will provide a patch soon.

Comment 4 Alex Chen

2010-09-29 04:29:23 EDT

Created attachment 179813 [details]
The patch for this issue

Comment 5 Alex Chen

2010-09-29 04:33:51 EDT

Hi Dear GMF guys,

Please review the patch I attached, basically, our product based on Eclipse 352, which include GMF org.eclipse.gmf.sdk_2.2.2.v20100209-2200-7C7I-BLxlyz-uojrqeOfnk4eytKd.

We need this patch to make our product works correctly.

Could you please help to create a feature patch to include this patch based on the GMF version we use? , which we can apply into our product?

Thanks in advanced!
--Alex Chen

Comment 6 Bingxue Xu

2010-10-11 17:13:21 EDT

Hi GMF team,

This is a ciritcal backward compatibility introduced by the newer GMF versions. Could you please review and provide some hotfix? Otherwise tons of user diagrams created using GMF 1.0.2 will be permamnetly damaged when we upgrade to new GMF releases. So this is not a minor bug.

Thanks very much.

Comment 7 Anthony Hunter

2010-10-12 10:50:20 EDT

Hi Alex, Lidija, can you review the attached patch? I do not think the patch is valid, can you confirm the increase does not break anything?

Comment 8 Alex Boyko

2010-10-12 16:45:38 EDT

Looks good to me. I'll look into delivering this patch

Comment 9 Alex Boyko

2010-10-15 10:59:31 EDT

Delivered the tolerance constant change to R1_4_maintenance and HEAD -> 2.3.2 release. The fix should also eliminate a small bend for newly created rectilinear connection when it's nearly a straight line.

Comment 10 Anthony Hunter

2010-10-20 11:50:56 EDT

Hi Alex B, can you also commit this to the R2_2_maintenance stream so that Alex C's team can patch for 2.2.2?

Comment 11 Alex Boyko

2010-10-20 12:10:32 EDT

Delivered the same fix to R2_2_maintenance