Bug 324533

Summary: [Progress] ProgressMonitorFocusJobDialog does not job image
Product: [Eclipse Project] Platform Reporter: Wendell Beckwith <wbeckwith>
Component: UIAssignee: Platform UI Triaged <platform-ui-triaged>
Status: NEW --- QA Contact:
Severity: enhancement    
Priority: P3 CC: remy.suen
Version: 3.6   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Wendell Beckwith CLA 2010-09-05 06:57:33 EDT
Build Identifier: I20100608-0911

The jobs article, http://www.eclipse.org/articles/Article-Concurrency/jobs-api.html, shows that you can set the image for the job by executing the following code inside the run method:

setProperty(IProgressConstants.ICON_PROPERTY, getImage());

However, the image only shows up in the progress view and not in the progress dialog.  This is because the ProgressMonitorFocusJobDialog never retrieves the custom info image like the ProgressInfoItem class with the following code

ImageDescriptor descriptor = null;
Object property = jobInfo.getJob().getProperty(ProgressConstants.ICON_PROPERTY);

Suggest refactoring the private getInfoImage() method in ProgressInfoItem to a utils class and to take a Job parameter (i.e. getInfoImage(Job job)). Then the method can be called by both the ProgressInfoItem and the ProgressMonitorFocusJobDialog classes to have a consistent UI.



Reproducible: Always

Steps to Reproduce:
1. Create a Job
2. Set the property IProgressConstants.ICON_PROPERTY to a custom image descriptor
3. See that the image is only set in the progress view.
Comment 1 Eclipse Webmaster CLA 2019-09-06 16:15:48 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.