Bug 315844

Summary: Provide the eclipse compiler batch bundle signed and published into the main P2 repository
Product: [Eclipse Project] Platform Reporter: Hugues Malphettes <hmalphettes>
Component: RelengAssignee: Kim Moir <kim.moir>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, david_williams, d_a_carver, jeffmcaffer, jesse.mcconnell, john.arthorne, kim.moir, Olivier_Thomann, pwebster, stephan.herrmann, tjwatson
Version: 3.6   
Target Milestone: 3.7 M3   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 327817    
Bug Blocks:    
Attachments:
Description Flags
patch
none
patch
none
patch none

Description Hugues Malphettes CLA 2010-06-04 17:25:34 EDT
This is a follow-up on bug 315644
Some projects such as Jetty depend on the eclipse java compiler executed in an OSGi runtime but without org.eclipse.runtime.

It would be nice to have that bundle published in the eclipse-platform repository and signed to be able to reuse it easily.
Comment 1 Olivier Thomann CLA 2010-06-08 14:06:24 EDT
Moving to Platform/Releng.
Comment 2 David Williams CLA 2010-10-07 20:39:54 EDT
This seems a reasonable request to me, on the surface, and suspect an evaluation and "yes/no" decision is needed soon? 

Can someone outline the basic steps required here? 

Is this a (merely) a matter of refactoring jdt.core so that the 
org.eclipse.jdt.core.compiler package(s) are in their own bundle? 

(sorry if obvious to others ... I've not loaded up the code).
Comment 3 Thomas Watson CLA 2010-10-08 08:15:19 EDT
I wonder if this is really a releng problem.  Seems like a new bundle is being requested that splits the content of jdt.core in two.  Either that or remove all core.runtime dependencies from the current jdt.core.  Correct?
Comment 4 Olivier Thomann CLA 2010-10-08 09:13:34 EDT
(In reply to comment #3)
> I wonder if this is really a releng problem.  Seems like a new bundle is being
> requested that splits the content of jdt.core in two.  Either that or remove
> all core.runtime dependencies from the current jdt.core.  Correct?
ecj.jar contains more than just the batch compiler from the org.eclipse.jdt.core project. It contains the jsr199 and jsr269 support (apt and compiler api support). That code is part of the two jdt.core fragments.
Comment 5 Jesse McConnell CLA 2010-10-08 10:16:49 EDT
for a bit more context we (jetty) have used this for a number of years as the jsp compiler with jetty and its dependency/requirement came in when we started including jsp support in our eclipse project.

so as long as we can maintain that support we are open to getting it in whatever form is reasonable, we just don't want to be trying to get it signed and into the p2 repo's via our project :)

cheers!
Comment 6 Kim Moir CLA 2010-10-08 10:33:53 EDT
So to clarify, what you are looking for is the ecj-${buildId}.jar published to our repository. Is that correct?
Comment 7 Jesse McConnell CLA 2010-10-08 10:43:37 EDT
Both the org.eclipse.jdt.core.compiler ecj jar and the associated sources, signed of course

cheers
jesse
Comment 8 Kim Moir CLA 2010-10-14 14:30:49 EDT
Created attachment 180902 [details]
patch
Comment 9 Kim Moir CLA 2010-10-15 14:43:28 EDT
Created attachment 181002 [details]
patch
Comment 10 Kim Moir CLA 2010-10-15 14:43:43 EDT
Created attachment 181003 [details]
patch
Comment 11 Kim Moir CLA 2010-10-15 15:36:25 EDT
This has been released for N20101015-2000.  The jars will look like this and will be reflected in the metadata of the repo

-bash-3.00$ unzip -l eclipse-master-N20101015-1446.zip | grep batch
  1311735  10-15-10 15:27   plugins/org.eclipse.jdt.core.compiler.batch.source_3.6.0.N20101015-1446.jar
  1687550  10-15-10 15:27   plugins/org.eclipse.jdt.core.compiler.batch_3.6.0.N20101015-1446.jar