Bugzilla – Full Text Bug Listing
| Summary: | StringIndexOutOfBoundsException is ASTRewrite | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Martin Aeschlimann <martinae> |
| Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | akiezun, kai-uwe_maetzel |
| Version: | 2.1 | ||
| Target Milestone: | 2.1 RC1 | ||
| Hardware: | PC | ||
| OS: | Windows 2000 | ||
| Whiteboard: | |||
|
Description
Martin Aeschlimann
Bug in the code formatter, positiosn retruned are greater than the length of
the string.
public void testBug31289() throws Exception {
// str-len == 100
String str= "protected X createCompilationUnitChange(int MISSING,int
MISSING,int MISSING) throws CoreException {}");
int[] pos= {10, 10, 40, 50, 52, 62, 64, 74, 98, 99 };
ICodeFormatter formatter= ToolFactory.createDefaultCodeFormatter(null);
String formatted= formatter.format(str, 1, pos, "\r\n");
int len= formatted.length();
for (int i= 0; i < pos.length; i++) {
assertTrue(pos[i] < len);
}
}
*** Bug 30880 has been marked as a duplicate of this bug. *** I tried your test case.
When you format:
String str= "protected X createCompilationUnitChange(int MISSING,int
MISSING,int MISSING) throws CoreException {}");
I end up with:
"protected X createCompilationUnitChange(int MISSING, int MISSING, int MISSING)
throws CoreException {
}"
which is 106 character long.
The positions are mapped to:
[10, 10, 40, 50, 53, 63, 66, 76, 102, 105]
98 and 99 are the positions of the '{' and '}' in the original source. They are
mapped to 102 and 105 which are the corresponding positions in the formatted source.
So I see no problem. Let me know what are your settings for the formatter. I
might not test the same thing.
Let me know what are the mapped positions you get and the formatted string.
Without further information, I cannot fix it. What I get looks ok to me. public class DeclTest extends TestCase {
public DeclTest(String name) {
super(name);
}
public static Test suite() {
return new DeclTest("testBug31289");
}
public void testBug31289() throws Exception {
Hashtable options= JavaCore.getDefaultOptions();
options.put(JavaCore.FORMATTER_TAB_CHAR, JavaCore.SPACE);
options.put(JavaCore.FORMATTER_TAB_SIZE, "4");
JavaCore.setOptions(options);
// str-len == 100
String str= "protected X createCompilationUnitChange(" +
"int MISSING,int MISSING,int MISSING) throws" +
" CoreException {}";
System.out.println("orig-length: " + str.length());
int[] pos= {10, 10, 40, 50, 52, 62, 64, 74, 98, 99 };
ICodeFormatter formatter=
ToolFactory.createDefaultCodeFormatter(null);
String formatted= formatter.format(str, 1, pos, "\r\n");
int len= formatted.length();
boolean isTooBig= false;
System.out.println("length: " + len + "\ncontent:\n" +
formatted);
for (int i= 0; i < pos.length; i++) {
System.out.print(", " + pos[i]);
isTooBig= isTooBig || (pos[i] < len);
}
assertFalse(isTooBig);
}
}
The output is
orig-length: 100
length: 149
content:
protected X createCompilationUnitChange(
int MISSING,
int MISSING,
int MISSING)
throws CoreException {
}
, 14, 14, 54, 64, 76, 86, 98, 108, 149, 152
Ok, I reproduced it. I will investigate. The bug is located in the mapping of positions during the line splitting. We know that this doesn't work very well. So you have two solutions: 1) don't try to map positions 2) don't try to split (increase the line split value). It is clearly to risky to change that code now. This code will disappear anyway as soon as the new code formatter is ready. I'm required to get the positions (have to replace certain pieces in the code), so I will disable the splitting. Kai, you might want to make sure that the editor can add a guard for the wrong positions out of range. fixed > 200302 Could you please verify this one as you fixed it? Thanks. |