Bug 31248

Summary:	Java Compiler progress monitor tells about probelms found
Product:	[Eclipse Project] JDT	Reporter:	Martin Aeschlimann <martinae>
Component:	Core	Assignee:	Kent Johnson <kent_johnson>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	philippe_mulet
Version:	2.1
Target Milestone:	2.1 RC1
Hardware:	PC
OS:	Windows 2000
Whiteboard:

Description Martin Aeschlimann

2003-02-07 06:42:33 EST

20030207

1. When compiling, the progress monitor names the file currently compiling and 
also informs, that e.g. 230 problems were found. However, when building is 
done, these problems seem to have been resolved (my sources are fine).
Are warnings also considered to be problems? Or is it possible that the 
compiler finds errors that can be resolved at a later point?

If it's just the warnings, I would vote that only the error count is shown and 
warnings ignored. It's very helpful to know while building that there are 
errors to be expected. However, we have so many warnings in our code, what 
makes the number shown irrelevant.

Comment 1 Philipe Mulet

2003-02-07 07:42:34 EST

Problem is generic term for error or warning. 

In incremental mode, the number could fluctuate while it is in the middle of 
recompiling (fixes problems and discovers new ones as it goes).

We could better inform the user of error vs. warning count instead of just 
problems.

Kent - the BuildNotifier knows about errors vs warnings, seems like a trivial 
change, isn't it ?

Would require a NLS change (need to check if it is still allowed)

Comment 2 Kent Johnson

2003-02-11 14:23:14 EST

Just need to change BuildNotifier.problemsMessage().

We can either report only found/fixed errors, or report both found/fixed errors 
& warnings.

Comment 3 Philipe Mulet

2003-02-12 05:12:48 EST

Please go for error+warning message (like we had in VAJ).

Comment 4 Kent Johnson

2003-02-12 16:20:55 EST

Philippe: I don't think there is enough room to include both errors & warnings.

This message is added before the compiling message AND must fit on one line. In 
some progress dialogs like PDE import, it is truncated so we shouldn't make it 
twice as long.

I think we should change from all problems to just errors.

I released the changes to the BuildNotifier & messages file, please double 
check.

Comment 5 Philipe Mulet

2003-02-13 08:43:44 EST

In case I change the severity of some configurable warning, I won't get a feel 
for discovered warnings, though it will rebuild all, with likely no more errors 
than it had in the past.

Can't we use a multiline message ? First line is problem count update, and next 
line is file/package being processed ?

Comment 6 Philipe Mulet

2003-02-13 08:54:01 EST

What if we display something like

Compiling org.eclipse.jdt.core: 23 errors found, 46 warnings fixed.
Processing srcfolder/packagename

Comment 7 Kent Johnson

2003-02-13 10:53:04 EST

No 'we' cannot display multiple lines.

The UI would need to change ALL progress dialogs to support a multi-line 
message, or at least handle wrapping intelligently. I don't see either of those 
things happening.

Comment 8 Kent Johnson

2003-02-13 16:43:16 EST

Ok, we used to display:

(x problems found, y problems fixed)

Now we'll display:

(Found: x errors, y warnings) when only new errors/warnings are found
(Fixed: x errors, y warnings) when only existing errors/warnings are fixed
(Found/fixed: x/y errors, x/y warnings) when some errors/warnings were found 
AND fixed

Comment 9 David Audel

2003-02-24 08:09:14 EST

Verified.