Bugzilla – Full Text Bug Listing
| Summary: | ToolFactory.createScanner(..) should use workspace compliance | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Olivier Thomann <Olivier_Thomann> | ||||||
| Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | amj87.iitr, daniel_megert, jarthana, markus.kell.r, srikanth_sankaran | ||||||
| Version: | 3.6 | ||||||||
| Target Milestone: | 3.6 M7 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Olivier Thomann
Created attachment 165609 [details]
Proposed fix
Under testing.
Is the Unicode level the only change that's controlled with the compliance level? If not, this may surprise some existing clients. I guess these methods also used to work without a workspace, so please make sure such scenarios are not broken. The Javadoc should also tell about the new default (and the the paragraph about 'strictCommentMode' can be removed, since it's not implemented). (In reply to comment #2) > Is the Unicode level the only change that's controlled with the compliance > level? If not, this may surprise some existing clients. yes. This is the only thing that the compliance checks. > I guess these methods also used to work without a workspace, so please make > sure such scenarios are not broken. This doesn't change with the proposed patch. > The Javadoc should also tell about the new default (and the the paragraph about > 'strictCommentMode' can be removed, since it's not implemented). I'll update the javadoc. Created attachment 165615 [details]
Updated patch with javadoc changes
Released for 3.6M7. Verified for 3.6M7 though code inspection Verified. |