Summary: | Differences between patch of bug 210422 and sources | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Stephan Herrmann <stephan.herrmann> | ||||
Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | minor | ||||||
Priority: | P3 | CC: | jarthana, Olivier_Thomann, philippe_mulet | ||||
Version: | 3.6 | ||||||
Target Milestone: | 3.7 M1 | ||||||
Hardware: | Other | ||||||
OS: | All | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Stephan Herrmann
2010-03-30 09:36:32 EDT
Philippe, could you please comment since you released the bug 210422? Thanks. (In reply to comment #0) > I'm currently wondering if this was intended or by accident? > If the field anonymousOriginalSuperType is not needed it should probably > be deleted completely; also the ctor arg. I think we should clean up that code. Unfortunately I don't actually plan to clean up the patch for bug 210422. (In reply to comment #2) > I think we should clean up that code. Unfortunately I don't actually plan to > clean up the patch for bug 210422. Is that you're asking for help or are you just stating that the cleanup will not be reflected back as a patch attached to bug 210422? (In reply to comment #3) > Is that you're asking for help or are you just stating that the cleanup > will not be reflected back as a patch attached to bug 210422? If you want to provide a patch attached to bug 210422, feel free to do so. It is unfortunate that the patch attached to this bug report is not what was released for this issue. But you are right that we should completely clean up the code for clarity. Created attachment 174440 [details]
Proposed fix
Stephan, please review.
This bug should be fixed once the cleanup is done. Hi Olivier, without fully understanding how the current situation relates to bug 210422, yes, your patch looks safe. And the original reason why I was puzzled is resolved. So, thanks, feel free to close this bug. Released for 3.7M1. Verification must be done by looking at the source code. Verified for 3.7M1 by code inspection. |