Bug 307171

Summary:	[FieldAssist] ContentProposalAdapter should support storing of popup dialog size
Product:	[Eclipse Project] Platform	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	daniel_megert, remy.suen
Version:	3.6	Keywords:	api
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Markus Keller

2010-03-26 07:24:32 EDT

I20100323-0800

ContentProposalAdapter should support storing of popup dialog size. The used PopupDialog already supports this via getDialogSettings() and getPersistSize(), but this is not available via API on ContentProposalAdapter.

A place where I notice this all the time is Regex content assist in the Find/Replace dialog. Each time I open the dialog, I have to resize the popup.

Comment 1 Eric Moffatt

2010-04-22 13:46:34 EDT

Markus, doesn't this dialog show different content every time (potentially) ?

If so wouldn't it make more sense to just have it pick an appropriate size based on the current contents? It's sort of like the preference page handling, some pages need *lots* of space but most don't.

Comment 2 Markus Keller

2010-04-22 15:09:11 EDT

(In reply to comment #1)
It's like the content assist popup in the editor: We never know how much content there is to show, so we let the user choose a size. It already works like that today -- the size is just not persisted when the field is disposed.

Choosing the size based on current contents would not be a good strategy, since in general, the contents can grow and shrink if the user continues editing the field while the popup is open, therefore setting the size only based on the initial content would not be appropriate.

Comment 3 Eclipse Webmaster

2019-09-06 16:09:45 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.