Bug 305100

Summary:

Add Facelets plugins to jst features

Product:

[WebTools] WTP Java EE Tools

Reporter:

Raghunathan Srinivasan <raghunathan.srinivasan>

Component:

jst.j2ee

Assignee:

David Williams <david_williams>

Status:

RESOLVED FIXED

QA Contact:

Chuck Bridgham <cbridgha>

Severity:

normal

Priority:

CC:

david_williams

Version:

unspecified

Target Milestone:

3.2 M6

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch to add Facelet support plugins	none

Description Raghunathan Srinivasan

2010-03-09 00:40:30 EST

The attached patch adds the facelet.core and facelet.ui plugin to the correspondig features: org.eclipse.jst.web_core.feature and org.eclipse.jst.web_ui.feature

Comment 1 Raghunathan Srinivasan

2010-03-09 00:41:33 EST

Created attachment 161410 [details]
Patch to add Facelet support plugins

Comment 2 Raghunathan Srinivasan

2010-03-10 14:16:28 EST

We need this to be released for M6. Can someone checkin this today?

Comment 3 David Williams

2010-03-10 20:14:51 EST

I confirmed these bundles are in JSF maps with a recent tag. I assume they themselves are ready to build. I've released the features to the next (final?) S-build. 

Let's keep track ... number of new plugins added in final M6 stabilization week: 3? :/

Comment 4 David Williams

2010-03-10 21:00:24 EST

Sorry, didn't mean to change the 'p1' part. 

In case not obvious, this was 'p1' since JSF 2.0 is a major requirement for this release.

Comment 5 David Williams

2010-03-10 22:22:56 EST

This caused a build break because one of the new bundle has dependency on JPT. 

I'm pretty sure it doesn't really have such a dependency, but we can't build it until its manifest is corrected. Perhaps all dependencies should be double checked?

Comment 6 Raghunathan Srinivasan

2010-03-10 22:59:41 EST

(In reply to comment #5)
> This caused a build break because one of the new bundle has dependency on JPT. 
> I'm pretty sure it doesn't really have such a dependency, but we can't build it
> until its manifest is corrected. Perhaps all dependencies should be double
> checked?

yes, this dependecy is not required. I am reviweing othe dependencies too. I will commit the chnage once I clean up the dependency. Not clear why I see it only with the latest WTP build and depenedencies.

Comment 7 Raghunathan Srinivasan

2010-03-10 23:59:38 EST

Removed unwanted dependency on JPT in facelet.ui plugin. Request re-release of the feature.xml with the facelt plugins.

Comment 8 David Williams

2010-03-11 10:24:26 EST

I did re-release this late last night, but wanted to let that running build finish. In parallel, I did do a local build with these in, and it did complete. So, should be in next build later today.