Bug 304925

Summary: [CommonNavigator] Allow command-based to be contributed to CommonNavigator without fear of duplication
Product: [Eclipse Project] Platform Reporter: Francis Upton IV <francisu>
Component: UIAssignee: Francis Upton IV <francisu>
Status: NEW --- QA Contact:
Severity: enhancement    
Priority: P3 CC: batxut
Version: 3.6   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
Work in progress
none
Another draft of work in progress none

Description Francis Upton IV CLA 2010-03-06 20:55:44 EST 
You can currently contribute command-based menu items to the common navigator (like any other view) using the standard command menuItemContribution extension. However, it multiple unrelated plugins are contributing the same commands, this will result in a duplication of these in the menu.

Add support in the common navigator extensions to allow these menu items from the same command to be contributed only once, even if they are seen in multiple plugins in a similar manner as the current CNF action provider mechanism.

This will help encourage the use of commands with the CNF.
Comment 1 Francis Upton IV CLA 2010-03-06 21:00:10 EST 
Created attachment 161232 [details]
Work in progress

This is a little rough, and needs tests.
Comment 2 Francis Upton IV CLA 2010-03-06 22:59:05 EST 
Created attachment 161234 [details]
Another draft of work in progress

With just the start of the CopyHandler and PasteHandler (they don't even compile -- I don't have time to do that right now).

While I think this is a good direction to go, I'm nervous about the interaction between the Actions and commands and overriding and stuff, so putting this in late in the M6 cycle seems wrong (even for me).  This is probably something to be explored early in 3.7.
Comment 3 Francis Upton IV CLA 2010-03-06 23:10:50 EST 
Need to fix the work in progress in NavigatorContentService when it binds the menu items to not create the factory inside of the loop, but to create it once for the whole binding.
Comment 4 Eclipse Webmaster CLA 2019-09-06 16:13:53 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.