Bug 304052

Summary: [preferences] Add new 'code formatter' options to disable formatting of line/block comments starting on first column
Product: [Eclipse Project] JDT Reporter: Frederic Fusier <frederic_fusier>
Component: UIAssignee: Markus Keller <markus.kell.r>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: deepakazad, markus.kell.r, Olivier_Thomann
Version: 3.6   
Target Milestone: 3.6 M6   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 251133    
Bug Blocks:    
Attachments:
Description Flags
Proposed rough patch
none
Patch 2 none

Description Frederic Fusier CLA 2010-02-26 11:09:01 EST 
Once bug 251133 is fixed, the two new constants to disable/enable the formatting of block/line comments which start on first column need to be exposed in the code formatter preference page.
Comment 1 Frederic Fusier CLA 2010-02-26 11:17:55 EST 
Created attachment 160325 [details]
Proposed rough patch

This patch adds two check boxes in the 'General settings' group in
the 'Comments' tab of the formatter preference page.

I tried to implement the corresponding UI behavior to make the corresponding indentation check-box dependent of the format check-box. It seems to roughly work but I got some trouble with the initialization, hence this patch surely needs a little bit more work to be finalized...

However, I hope this helps a little bit :-)
Comment 2 Markus Keller CLA 2010-02-26 11:58:34 EST 
I'll probably create a new 'Line comment settings' group and move the 4 checkboxes to their groups.
Comment 3 Markus Keller CLA 2010-03-02 07:13:06 EST 
Created attachment 160608 [details]
Patch 2

UI for bug 251133 comment 12 (dependency for new option temporarily disabled).
Comment 4 Markus Keller CLA 2010-03-04 12:26:56 EST 
Forgot to close this bug, has been released yesterday.
Comment 5 Deepak Azad CLA 2010-03-09 00:36:44 EST 
Verified with I20100308-1300 for 3.6 M6.