Summary: | need to remove most, change a few, webtools repository URL in feature.xml | ||
---|---|---|---|
Product: | [WebTools] WTP Releng | Reporter: | David Williams <david_williams> |
Component: | releng | Assignee: | David Williams <david_williams> |
Status: | RESOLVED FIXED | QA Contact: | David Williams <david_williams> |
Severity: | normal | ||
Priority: | P1 | CC: | d_a_carver, konstantin, neil.hauge |
Version: | unspecified | Flags: | david_williams:
pmc_approved+
david_williams: pmc_approved? (raghunathan.srinivasan) david_williams: pmc_approved? (naci.dai) david_williams: pmc_approved? (deboer) neil.hauge: pmc_approved+ david_williams: pmc_approved? (kaloyan) |
Target Milestone: | 3.10.0 | ||
Hardware: | PC | ||
OS: | Windows 7 | ||
Whiteboard: | PMC_approved | ||
Bug Depends on: | 314133, 314135, 314137 | ||
Bug Blocks: |
Description
David Williams
2010-02-25 12:15:31 EST
There's another twist to this ... Having this URL in each feature is not needed, doesn't do anyone any good, and should be removed from all features, except for those that can be expected to be installed "on its own" via some known package or distribution. That is, we'd pick just a 2 or 3 "key" features. provide the update URL in them, and simply omit it from all others. This is a difference in the whole p2 update concepts ... where being in the update URL gets something added to the software sites list (so, being in multiple features does no good). Likewise, we should just remove any mention of "discovery URL". There's some subtle differences, where its default state will be "enabled" but that doesn't seem like a big need, and in most cases not desired. So, I think only two features _need_ the URL: jsdt and xml_ui I think any other package or distribution would have one of these features. There might be others desired, where components are used "stand alone" (e.g. xpath2 processor? One fproj feature? But, I'll let those owners decide. Perhaps in those contexts, you wouldn't want to provide an update URL anyway? So, I'll start working on removing many. I the few cases we want to list one, I'd like to propose the "name" be standardized on # "updateSiteName" property - label for the update site updateSiteName=Eclipse Web Tools Platform (WTP) Repository and the URL standardized to <url> <update label="%updateSiteName" url="http://download.eclipse.org/webtools/repository/helios"/> </url> Dave, adding you to CC. Since it will be incorrect, I removed the update URL in org.eclipse.wst.xml.xpath2.processor.feature If you think there's some standalone install scenarios where users would want or get the URL from this feature, feel free to add back correct one. (But, in many scenarios, they may have it there already). Konstantin, add you explicitly to CC. Since the URL will be incorrect, I removed the update URL from org.eclipse.wst.common.fproj.feature If there are some stand-alone scenarios, where this feature needs to provide its own update URL, please feel to add back a correct one. (But, as mentioned, in many cases the URL will be in software sites list anyway, from other means). Thanks for the head's up David. I do not see a big issue with not including the update site URL in the fproj feature. (In reply to comment #4) > Dave, adding you to CC. Since it will be incorrect, I removed the update URL in > > org.eclipse.wst.xml.xpath2.processor.feature > > If you think there's some standalone install scenarios where users would want > or get the URL from this feature, feel free to add back correct one. (But, in > many scenarios, they may have it there already). This should be fine. Most standalone scenarios are non-eclipse scenarios for the PsychoPath processor, so they won't even be using the update repository url in this case. They can grab a jar from Hudson if they need it. appears all fixed. Will confirm as RC3 rolls out. Looks like I missed releasing one for RC3, wst.common.fproj so I have released it for RC4. Have rebuilt RC3 to pick this up. |