Summary: | Regression: A build doesn't cancel if I tell it to Cancel | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | swright | ||||||
Component: | Ant | Assignee: | Darin Wright <darin.eclipse> | ||||||
Status: | VERIFIED FIXED | QA Contact: | |||||||
Severity: | critical | ||||||||
Priority: | P3 | CC: | daniel_megert, darin.eclipse, markus.kell.r, Michael_Rennie, remy.suen | ||||||
Version: | 3.4.2 | Keywords: | polish | ||||||
Target Milestone: | 3.6 M7 | Flags: | markus.kell.r:
review+
|
||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Whiteboard: | |||||||||
Attachments: |
|
Description
swright
2010-02-02 18:26:19 EST
(In reply to comment #0) > Try to build a project and then try to force it to cancel. Since you mention a build.xml, this is an Ant build? Does the Ant build kick off other processes? Do you get this problem with building a regular Java project? Is the problem reproducible? If yes, can you attach a thread dump? http://wiki.eclipse.org/How_to_report_a_deadlock Created attachment 162530 [details]
build.xml
This works fine for me in 3.5.2.
In I20100316-0859, I can reproduce with these steps:
- create an Ant launch config for the attached build.xml
- on the JRE tab, check "Run in the same JRE as the workspace"
- run as Ant build
=> Terminate button in Debug view is initially enabled, but clicking it only disables the button but does not stop the Ant build.
=> Terminate button in Console stays enabled, but clicking it does nothing.
could be related to the bundle split from bug 264338 Also reproduced on Linux and Mac, updating platform... Created attachment 165782 [details]
patch
There were two issues here. (1) The launcher was incorrectly launching in the foreground (when launch in background was checked). (2) The Ant process needs to wrapper the launch progress monitor when running in the foreground.
Problem (1) was introduced when splitting the ant/external tools launcher into headless code. External tool builders run synchronously by default, where as ant launches do not.
Fixed. Please verify, Markus. Verified in N20100422-2133. |