Bug 301452

Description John Arthorne 2010-02-01 14:24:50 EST

The "unnecessary @SuppressWarnings" warning is currently difficult to use because it is sensitive to the particular compiler settings at the time of compilation. This means everyone who is browsing or working with a particular piece of code must use the same compiler settings, or else suffer from "unnecessary @SuppressWarnings" warnings.

For example, if user 1 has set usage of raw types to be "warning", and user 2 has set usage of raw types to "ignore" or "error", then it is impossible for both users to have warning-free code containing a raw reference (if @SuppressWarnings is added then user 2 has a compiler warning, and without it user 1 will have a warning). We keep getting bitten by this in p2 because we like to have more strict warning levels in our workspaces than we have in the formal build.

This request is to make the "unnecessary @SuppressWarnings" warning consistent with the warning settings on the project. I.e., only flag "unnecessary @SuppressWarnings" for problem type X if X has a severity level of "warning" in the compiler settings. If the severity for problem type X is "error" or "info", then simply ignore any @SuppressWarnings annotation for that problem type. If you're ignoring the warning it's reasonable to ignore the warning about the warning...