Bug 298981

Summary: org.eclipse.jdt.internal.core.search.indexing.AddJarFileToIndex.execute(IProgressMonitor) causes performance degradation
Product: [Eclipse Project] JDT Reporter: Kenneth Cheung <kennethc>
Component: CoreAssignee: Frederic Fusier <frederic_fusier>
Status: VERIFIED INVALID QA Contact:
Severity: normal    
Priority: P3 CC: frederic_fusier, Olivier_Thomann, satyam.kandula, srikanth_sankaran
Version: 3.4.2Keywords: needinfo
Target Milestone: 3.6 M5   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
The jar file triggering the call of the method none

Description Kenneth Cheung CLA 2010-01-06 14:21:32 EST 
Build Identifier: org.eclipse.jdt.core_3.4.9.v_899_R34x.jar

In our adopting product, we need to maintain performance from release to release.

In one of our scenario, with org.eclipse.jdt.core_3.4.9.v_899_R34x.jar, the method:

org.eclipse.jdt.internal.core.search.indexing.AddJarFileToIndex.execute(IProgressMonitor) 

takes 1015ms, while with org.eclipse.jdt.core_3.4.4.v_894_R34x.jar it takes 0ms

Reproducible: Always
Comment 1 Kenneth Cheung CLA 2010-01-06 14:25:00 EST 
Created attachment 155442 [details]
The jar file triggering the call of the method
Comment 2 Olivier Thomann CLA 2010-01-06 14:39:17 EST 
That code has not changed since the 3.4 release. So I don't see how it could be suddenly much slower.
Could you please describe how you got the numbers?
Comment 3 Olivier Thomann CLA 2010-01-07 10:00:49 EST 
Please confirm that the same jar file is indexed on both cases.
Comment 4 Olivier Thomann CLA 2010-01-07 11:38:14 EST 
Right now nothing can be done on our side as that code has not changed in the two versions mentionned in comment 0.
Comment 5 Frederic Fusier CLA 2010-01-12 06:23:27 EST 
I got a setup on a remote machine and it appears that the added jar file only contains source files. I have observed that the AddJarFileToIndex.execute method is never called during the test!

Hence, close this bug as invalid...
Comment 6 Satyam Kandula CLA 2010-01-25 06:26:27 EST 
Verified for 3.6M5 using Build id: I20100122-0800
Comment 7 Srikanth Sankaran CLA 2010-01-25 06:28:42 EST 
Verified.