Bug 297227

Summary:	[Undo] IOperationHistory does not indicate if execute() failed due to IOperationApprover2
Product:	[Eclipse Project] Platform	Reporter:	Min Idzelis <min123>
Component:	IDE	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	pwebster
Version:	3.5
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Min Idzelis

2009-12-08 11:14:16 EST

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091102 Firefox/3.5.5
Build Identifier: 

The DefaultOperationHistory history as written does not differentiate between execute invocations that fail due to faulty operation execution vs operations that fail due to denial by IOperationApprover2. 

There should be a special status (like IOperationHistory.OPERATION_INVALID_STATUS) that is returned when approval fails. 

This is important to me because there is a operation approval that performs validateEdit before executing the operation. Typically, I open an error dialog whenever there is problem during execution. The problem is that the validateEdit operation approval decided that the operation should not run and opened a error dialog. Since the approval already opened a dialog, I do not want to open a dialog again. 

Even if you think that the approval shouldn't be opening dialogs, I still think it is valid to know when execution fails due to an approval. I think the approval that fails should be allowed to return a string message, but I think there should be a IStatus error code that indicates that the approval failed. 


Reproducible: Always

Comment 1 Eclipse Webmaster

2019-09-06 16:10:54 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.