Bugzilla – Full Text Bug Listing
| Summary: | [formatter] The comment formatter add an unexpected new line in block comment | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Frederic Fusier <frederic_fusier> | ||||||||
| Component: | Core | Assignee: | Frederic Fusier <frederic_fusier> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | satyam.kandula, srikanth_sankaran | ||||||||
| Version: | 3.6 | ||||||||||
| Target Milestone: | 3.6 M4 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
Created attachment 152292 [details]
Proposed patch
With this patch the number of unstable formatting decrease from 526 to 4 on the Eclipse 3.0 full source workspace... :-)
Created attachment 152322 [details]
New proposed patch
Previous patch was missing one place to set the added bufferHasNewLine local variable. Note that it also adds similar missing set for the already existing bufferHasTokens local variable (see test cases b2 and b3)...
Released for 3.6M4 in HEAD stream. Verified for 3.6M4 using I20091207-1800 |
Created attachment 152291 [details] Test case to reproduce the problem Build I20091110-0800 but happens since the 'Never join lines' preference has been added (i.e. 3.5.0) Consider the test case attached to this bug, format several times it using Eclipse built-in profile + 'Never join lines' preference checked on comment... A new line is always added after the @see tag line, hence makes the formatter unstable!