Bugzilla – Full Text Bug Listing
| Summary: | [formatter] The formatter takes two passes to format a common sequence of html tags | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Frederic Fusier <frederic_fusier> | ||||
| Component: | Core | Assignee: | Frederic Fusier <frederic_fusier> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | Olivier_Thomann, satyam.kandula, srikanth_sankaran | ||||
| Version: | 3.6 | ||||||
| Target Milestone: | 3.6 M4 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Using 3.3.2, the formatter directly produces the last output, hence this one is a real regression... Created attachment 151748 [details]
Proposed patch
In this peculiar sequence, the last html tag taken into account was <p> which supposes to have a new line after its closing tag. But here, there's no closing tag for <p>, hence no new line needs to be added after the end of the text.
Modify the return of the printJavadocHtmlTag(...) method to return the correct value when the html tag does not really end with a closing tag...
Released for 3.6M4 in HEAD stream. Verified for 3.6M4 using Build id: I20091207-1800 |
Build 3.6M3 but exists since 3.4. Consider the following test case: package wkps3; /** * This comment makes the formatter unstable: * * <ol> * <li><p> first line * second line</li> * </ol> */ public class X { } The format output when using Eclipse built-in profile is: package wkps3; /** * This comment makes the formatter unstable: * * <ol> * <li> * <p> * first line second line * </li> * </ol> */ public class X { } And format it again produces the following different output: package wkps3; /** * This comment makes the formatter unstable: * * <ol> * <li> * <p> * first line second line</li> * </ol> */ public class X { }