Bug 292430

Summary:	Convert Search view contributions to new command/action story
Product:	[Eclipse Project] Platform	Reporter:	Craig Foote <CraigFoote>
Component:	Search	Assignee:	Platform-Search-Inbox <platform-search-inbox>
Status:	ASSIGNED ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	daniel_megert, gautier.desaintmartinlacaze, lafeuil
Version:	3.5	Keywords:	helpwanted
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Craig Foote

2009-10-15 12:45:20 EDT

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4) Gecko/20091007 Firefox/3.5.4
Build Identifier: 3.5.1.r351_v20090708-800

We are using the org.eclipse.search's SearchView and providing our own implementation of ISearch, ISearchResult and ISearchResultPage. We need to remove the "Cancel" button from the view's toolbar. Normally we would create an Activity extension in a fragment giving the extension the id of the action we wish to filter. The CancelSearchAction however has a null id. This means we have to take a copy of the org.eclipse.search project and alter it for our use, and repeat this every time we upgrade our eclipse version.

The CancelSearchAction should either be given an Id or replaced with Command framework artifacts.

Reproducible: Always

Steps to Reproduce:
1.Debug initializeToolbar() in SearchView, examine fCancelAction as it's contributed to toolbar, confirm null Id.

Comment 1 Dani Megert

2009-10-16 10:39:43 EDT

AFAIK activities don't filter local toolbar items. Can you provide a patch that adds the ID to the action plus an activity extension that show it's working?

Comment 2 Dani Megert

2009-10-19 04:01:04 EDT

Just double-checked: activities are not applied to local toolbars hence adding the IDs won't help you at all.

Comment 3 Craig Foote

2009-10-19 12:42:24 EDT

You are correct, sorry about that Dani. Should this ticket be changed to read CancelSearchAction should be replaced by a Command framework contribution or should I create another ticket?

Craig

Comment 4 Dani Megert

2009-10-20 03:07:49 EDT

See also bug 213385.

We won't have time to work on this.

Comment 5 Craig Foote

2009-10-20 18:51:04 EDT

(In reply to comment #4)
> See also bug 213385.
> 
> We won't have time to work on this.

Ever? 3.5.2? More info please.

Comment 6 Dani Megert

2009-10-21 02:47:24 EDT

>Ever? 3.5.2? More info please.
Sure not 3.5.2 as this is a maintenance release and no plans for 3.6 and beyond so far.