Summary: | Enhance declare error to support type patterns | ||
---|---|---|---|
Product: | [Tools] AspectJ | Reporter: | Matthew Adams <matthew> |
Component: | Compiler | Assignee: | aspectj inbox <aspectj-inbox> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P2 | CC: | aclement |
Version: | unspecified | ||
Target Milestone: | 1.6.9M1 | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: |
Description
Matthew Adams
2009-10-14 10:07:24 EDT
put some thought into this for 1.6.7 After some initial thinking, I'm looking at these constructs: declare type warning: <typepattern>: <message> declare type error: <typepattern>: <message> committed basic support for this. Syntax is the same as for regular deow declare warning: hasmethod(* foo(..)): "" there is no 'declare type warning'. Very nice! Just curious: why no "declare type warning"? No time to do it, or is there some more fundamental issue? "declare type warning" requires me to define a new pseudo token 'type' and modify the grammar, regenerate the parser then re-integrate the generated parser into the compiler. That is a very messy process. Overloading "declare warning" requires none of that. Please confirm: * There are two constructs "declare warning" and "declare error" and they can take type expressions or pointcut expressions. * There are no "declare type error" and "declare type warning" statements. > There are two constructs "declare warning" and "declare error" and they can > take type expressions or pointcut expressions. > > There are no "declare type error" and "declare type warning" statements. that's right. Excellent! Thanks for adding that! |