Summary: | [hotbug] Make Java EE Module Dependencies page optional | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [WebTools] WTP Java EE Tools | Reporter: | Rob Stryker <stryker> | ||||||
Component: | jst.j2ee | Assignee: | Carl Anderson <ccc> | ||||||
Status: | RESOLVED FIXED | QA Contact: | Chuck Bridgham <cbridgha> | ||||||
Severity: | normal | ||||||||
Priority: | P1 | CC: | ccc, deboer, juergen.zimmermann, kaloyan | ||||||
Version: | 3.1 | Flags: | ccc:
pmc_approved?
(david_williams) ccc: pmc_approved? (raghunathan.srinivasan) ccc: pmc_approved? (naci.dai) deboer: pmc_approved+ ccc: pmc_approved? (neil.hauge) kaloyan: pmc_approved+ cbridgha: review+ |
||||||
Target Milestone: | 3.1.1 | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Whiteboard: | PMC_approved | ||||||||
Attachments: |
|
Description
Rob Stryker
2009-08-24 12:18:42 EDT
This bug is quite important to that adopter. I'll do the initial investigation. Created attachment 145789 [details]
Add a preference and a PropertyTester
I added a J2EEPreference called showJavaEEModuleDependencyPage. If this is set to anything besides true (as per Boolean.parseBoolean()), the Java EE Module Dependency page will not appear in any project's properties.
Please note that the J2EEPreferencePropertyTester is an extremely generic and flexible class that can be used to test the boolean value of any J2EEPreference, and can thus key enablement of various sections of code, both via code and via injection into the plugin.xml (as in this case).
Accepting this as a hotbug. Created attachment 145977 [details]
Add a product preference, too
It seems the product setting is only used as the default value and that this can be overridden via API and setting the preference directly? (IE some other setting page which could change the preference and re-enable the page) If that's the case, this is a great patch. Flexible and satisfies all usecases. Patches look good. Yes Carl did a good job looking to the future for other applications of this solution This is a hotbug. There is no workaround. I ran the entire jeetools JUnit suite against it. I also tested this by hand, using both the default and a mocked up product preference usage. No test case nor JUnit have been added. Simply put, a product preference has been added that allows adopters to prevent the Java EE Module Dependencies page from showing. The default for this product preference is to show the Java EE Module Dependencies page. Chuck Bridgham has reviewed this fix. This is a low risk fix- only the Java EE Module Dependencies preference page is effected by this change. (And the change will have no effect on a default WTP set up.) Approving. In the future, please use the PMC approval template to speed approval. Committed to R3_1_maintenance for 3.1.1 and HEAD for WTP 3.2. (Note that if bug 277482 is finished, that will replace the Java EE Module Dependencies page in 3.2, and part of this will be removed.) |